Skip to content

fix(renderer): fixed onChange for single checkbox.#82

Merged
rvsia merged 1 commit into
masterfrom
fix-checkbox
Aug 12, 2019
Merged

fix(renderer): fixed onChange for single checkbox.#82
rvsia merged 1 commit into
masterfrom
fix-checkbox

Conversation

@Hyperkid123

Copy link
Copy Markdown
Member

Form onChange was missing field type checking for checkboxes.

@Hyperkid123 Hyperkid123 added bug Something isn't working renderer React form renderer PR labels Aug 12, 2019
@Hyperkid123 Hyperkid123 requested a review from rvsia August 12, 2019 07:21
@rvsia

rvsia commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

@Hyperkid123 please update snapshots 🙏

@codecov-io

codecov-io commented Aug 12, 2019

Copy link
Copy Markdown

Codecov Report

Merging #82 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   83.15%   83.28%   +0.12%     
==========================================
  Files          80       80              
  Lines        1306     1310       +4     
  Branches      310      311       +1     
==========================================
+ Hits         1086     1091       +5     
+ Misses        189      188       -1     
  Partials       31       31
Impacted Files Coverage Δ
...m-renderer/src/form-renderer/enhanced-on-change.js 100% <100%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2455d8...8b084d2. Read the comment docs.

@rvsia rvsia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🏆

@rvsia rvsia merged commit 055e1f6 into master Aug 12, 2019
@Hyperkid123 Hyperkid123 deleted the fix-checkbox branch August 12, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working renderer React form renderer PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants