Skip to content

Remove anonymous components#74

Merged
rvsia merged 2 commits into
masterfrom
remove-anonymous-components
Aug 5, 2019
Merged

Remove anonymous components#74
rvsia merged 2 commits into
masterfrom
remove-anonymous-components

Conversation

@Hyperkid123

Copy link
Copy Markdown
Member

fixes: #40

Changes

  • removed anonymous components from pf3 mapper
    • will now show component names in DOM properly
  • fixed missing prop types
  • fixed invalid prop types definitions in pf4 select component

@Hyperkid123 Hyperkid123 requested a review from rvsia August 5, 2019 09:04
@codecov-io

codecov-io commented Aug 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #74 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   82.76%   82.86%   +0.09%     
==========================================
  Files          79       79              
  Lines        1271     1278       +7     
  Branches      302      302              
==========================================
+ Hits         1052     1059       +7     
  Misses        188      188              
  Partials       31       31
Impacted Files Coverage Δ
...kages/pf4-component-mapper/src/form-fields/tabs.js 100% <ø> (ø) ⬆️
...f3-component-mapper/src/form-fields/form-fields.js 93.75% <ø> (ø) ⬆️
...ent-mapper/src/form-fields/multiple-choice-list.js 91.66% <ø> (ø) ⬆️
...ges/pf3-component-mapper/src/form-fields/button.js 100% <100%> (ø) ⬆️
...ponent-mapper/src/form-fields/layout-components.js 93.75% <100%> (+3.75%) ⬆️
...ent-mapper/src/form-fields/multiple-choice-list.js 100% <100%> (ø) ⬆️
...-component-mapper/src/form-fields/select/select.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d8600...c02965d. Read the comment docs.

@rvsia rvsia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@rvsia rvsia merged commit 19afa3f into master Aug 5, 2019
@Hyperkid123 Hyperkid123 deleted the remove-anonymous-components branch August 6, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove anonymous function components from mappers

3 participants