Data types feature by Hyperkid123 · Pull Request #67 · data-driven-forms/react-forms

Hyperkid123 · 2019-08-02T09:37:16Z

closes: #65

Adds data types casting to form fields (both default and custom)

enhances FieldProvider onChange function with type casting if the dataType prop has been given
supported data types
- integer
- float
- number
- boolean
- string

Hyperkid123 · 2019-08-02T09:38:30Z

rvsia · 2019-08-02T09:43:45Z

+  FLOAT: 'float',
+  NUMBER: 'number',
+  BOOLEAN: 'boolean',
+  STRING: 'stirng',


codecov-io · 2019-08-02T09:45:13Z

Codecov Report

Merging #67 into master will increase coverage by 0.29%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   82.76%   83.06%   +0.29%     
==========================================
  Files          79       80       +1     
  Lines        1271     1299      +28     
  Branches      302      310       +8     
==========================================
+ Hits         1052     1079      +27     
- Misses        188      189       +1     
  Partials       31       31

Impacted Files	Coverage Δ
packages/react-form-renderer/src/index.js	`100% <ø> (+100%)`	⬆️
...act-form-renderer/src/form-renderer/render-form.js	`100% <ø> (ø)`	⬆️
...ckages/react-form-renderer/src/validators/index.js	`89.02% <0%> (-1.1%)`	⬇️
...m-renderer/src/parsers/default-schema-validator.js	`98.36% <100%> (+0.21%)`	⬆️
...-form-renderer/src/form-renderer/field-provider.js	`100% <100%> (ø)`	⬆️
...ackages/react-form-renderer/src/constants/index.js	`100% <100%> (ø)`	⬆️
...m-renderer/src/form-renderer/enhanced-on-change.js	`87.5% <87.5%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0986487...755f93c. Read the comment docs.

rvsia · 2019-08-02T10:09:23Z

+ * Pick a value from event object and returns it
+ * @param {Object|Any} event event value returned from form field
+ */
+const sanytyzeValue = event =>


rvsia · 2019-08-02T10:11:30Z

    pattern: /^\d*[.]{0,1}\d*$/, message: 'Values mut be number', ...options,
  }),
+  float: options => pattern({
+    pattern: /^\d*[.]{0,1}\d*$/, message: 'Values mut be number', ...options,


mut > must be a number

rvsia · 2019-08-02T10:12:03Z

+## Introduction
+
+You can specify a type of a component by providing `dataType`, which will automatically validates the component value.
+Becuse almost everyting in html inputs is outputed as a string, adding the `dataType` props will also cast the value to given type.


Because.. everything

rvsia · 2019-08-02T10:12:10Z

+You can specify a type of a component by providing `dataType`, which will automatically validates the component value.
+Becuse almost everyting in html inputs is outputed as a string, adding the `dataType` props will also cast the value to given type.
+
+### Avaiable dataTypes


rvsia · 2019-08-02T10:18:24Z

Code looks solid! 👍 Just a few typos.. Need to test in UI. I like it, however, are we really make this feature as a default behavior? (To be honest, I haven't seen DataTypes used anywhere yet [except our demo schemas], but it can theoretically break some stuff if somebody uses it.)

Hyperkid123 · 2019-08-05T07:00:30Z

@rvsia it theoretically could break something but if yo are using data types and actually not expecting that data type in the output i don't thin it should be used at all. They can always remove it and just use validator.

rvsia · 2019-08-05T12:43:06Z

+### Available dataTypes
+
+```jsx
+['integer', 'float', 'number', 'bool', 'string']


we will make this bool because Mozilla parser returns bool (i know we won't be using it). Let me fix it in the mapper.

what about to allow both?

Nvm it is actually boolean

rvsia

Please add dataType validator to renderer, otherwise, it works perfectly! 👍 📈

martinpovolny · 2019-08-05T12:47:23Z

Looks good!

Hyperkid123 added enhancement New feature or request renderer React form renderer PR labels Aug 2, 2019

Hyperkid123 requested review from martinpovolny and rvsia August 2, 2019 09:37

rvsia reviewed Aug 2, 2019

View reviewed changes

Hyperkid123 force-pushed the data-types-feature branch from dc22e60 to 9a26b28 Compare August 2, 2019 09:45

rvsia reviewed Aug 2, 2019

View reviewed changes

rvsia mentioned this pull request Aug 2, 2019

fix(pf4textfield): send number as a number #62

Closed

Hyperkid123 force-pushed the data-types-feature branch from 9a26b28 to 70ad7c1 Compare August 5, 2019 06:59

rvsia reviewed Aug 5, 2019

View reviewed changes

rvsia requested changes Aug 5, 2019

View reviewed changes

Hyperkid123 force-pushed the data-types-feature branch 3 times, most recently from 2d12716 to 5c8dc51 Compare August 5, 2019 13:04

Hyperkid123 added 3 commits August 5, 2019 15:45

feat(renderer): Added dataType casting to form fields.

59ae284

Added docs page for dataTypes.

dd46f51

Added data type property validation to schema validator.

755f93c

Hyperkid123 force-pushed the data-types-feature branch from 5c8dc51 to 755f93c Compare August 5, 2019 13:46

rvsia approved these changes Aug 5, 2019

View reviewed changes

rvsia merged commit 7c638c7 into master Aug 5, 2019

Hyperkid123 deleted the data-types-feature branch August 6, 2019 06:42

Conversation

Hyperkid123 commented Aug 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hyperkid123 commented Aug 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Aug 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rvsia commented Aug 2, 2019

Uh oh!

Hyperkid123 commented Aug 5, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rvsia left a comment

Choose a reason for hiding this comment

Uh oh!

martinpovolny commented Aug 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hyperkid123 commented Aug 2, 2019 •

edited

Loading

codecov-io commented Aug 2, 2019 •

edited

Loading