Skip to content

fix(pf4): migrate to css for select styles.#60

Merged
rvsia merged 1 commit into
masterfrom
react-select-pf4-styles
Aug 1, 2019
Merged

fix(pf4): migrate to css for select styles.#60
rvsia merged 1 commit into
masterfrom
react-select-pf4-styles

Conversation

@Hyperkid123

Copy link
Copy Markdown
Member

closes #59

  • use scss instead of css in JS for pf4 select component.

@codecov-io

codecov-io commented Jul 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #60 into master will decrease coverage by 0.43%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage    83.2%   82.76%   -0.44%     
==========================================
  Files          73       79       +6     
  Lines        1280     1271       -9     
  Branches      302      302              
==========================================
- Hits         1065     1052      -13     
- Misses        184      188       +4     
  Partials       31       31
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/select/select.js 100% <ø> (+3.84%) ⬆️
...4-component-mapper/src/form-fields/select/input.js 0% <0%> (ø)
...t-mapper/src/form-fields/select/value-container.js 100% <100%> (ø)
...apper/src/form-fields/select/dropdown-indicator.js 100% <100%> (ø)
...apper/src/form-fields/select/multi-value-remove.js 100% <100%> (ø)
...er/src/form-fields/select/multi-value-container.js 100% <100%> (ø)
...-component-mapper/src/form-fields/select/option.js 66.66% <66.66%> (ø)
...t-mapper/src/form-fields/select/clear-indicator.js 80% <80%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73223bb...379f628. Read the comment docs.

@@ -0,0 +1,13 @@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line

);

export default MultiValueRemove;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line II.

};

export default ValueContainer;

@rvsia rvsia Jul 31, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line III.

@rvsia rvsia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great! Just a few unnecessary lines! 🍨

@Hyperkid123 Hyperkid123 force-pushed the react-select-pf4-styles branch from f405236 to 379f628 Compare August 1, 2019 07:23
@rvsia rvsia merged commit 47d8600 into master Aug 1, 2019
@Hyperkid123 Hyperkid123 deleted the react-select-pf4-styles branch August 1, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PF4 PF4 pull request Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use css for select component instead of css in js

3 participants