Fix PHP 8 incompatibilities#3
Merged
Merged
Conversation
Closed
Owner
|
Thanks, sorry I didn't notice this earlier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of dynamic property is deprecated in modern PHP 8. I think it was just a mistake in both cases as the rest of the code looks really good.
This is relevant for the magic border detection feature in https://croptool.toolforge.org that currently doesn't work because of this. @danmichaelo, do you think it's possible to release this and forward it to the CropTool codebase to see if this alone already solves the problem?