Copy HTTP client#261
Merged
Merged
Conversation
nhooyr
reviewed
Sep 24, 2020
nhooyr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for contributing @swithek!
Thoughts on instead of removing the timeout completely, copying the client and removing it in Dial and then using whatever timeout is on the client on the Dial context?
That way things would just work as expected.
Contributor
Author
|
@nhooyr that's a good point, I will submit an update soon. |
Contributor
Author
|
@nhooyr is there anything else that needs improving? |
Contributor
|
Nope, looks great. Thanks for contributing @swithek <3 |
nhooyr
approved these changes
Oct 2, 2020
Closed
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
Allow *http.Client with Timeout set
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #260