Remove unneeded resume() call - #29
Conversation
|
Thanks for providing this PR, very much appreciated! 👍 Could you please describe the necessary steps to reproduce this? Given the current code flow, there's little chance that this method call will actually be the cause of any error message. The That being said, there's current no test case that shows that this method is required in first place, so I'm okay with removing it altogether as per your PR :) |
|
Thank you reply. My working this repository, https://github.com/iwai/react-resque |
Nice, I'll certainly keep an eye on this :) I've also started working on a similar project (php-resque-react) a few months ago.
Please let me know if you manage to reproduce this. If you need any help, post in this issue or check out #reactphp on irc.freenode.org, thanks! |
See also reactphp/stream#18 which will be addressed via reactphp/stream#40. |
|
Alright, let's get this in To be clear: I do not consider this a bug fix, however I see no need to keep this method call because it should be a NOOP anyway. |
Fixed
PHP Warning: fread(): 294 is not a valid stream resource in .../react/stream/src/Stream.php on line 127Call Stream::resume in https://github.com/reactphp/stream/blob/master/src/Stream.php#L40
Perhaps this problem, Read Stream Listener is not successfully deleted when you close the connection, warning came out after a while.
Code to strictly reproduce is difficult, but it was caused by my production.
This pull request, because the first time that for me, there may be a problem with the manners, but please forgive me. and i'm afraid my expressions may be rude or hard to read, because I'm not so good at English.