Skip to content

test(e2e): assert invalid multipart error log #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chimurai merged 1 commit into from
Jun 23, 2026
Merged

test(e2e): assert invalid multipart error log #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/e2e/http-proxy-middleware.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ describe('E2E http-proxy-middleware', () => {

it('should reject CRLF multipart injection when fixRequestBody serializes multipart', async () => {
const targetSpy = vi.fn();
const loggerSpy: Logger = {
info: vi.fn(),
warn: vi.fn(),
error: vi.fn(),
};

agent = request(
createApp(
Expand All @@ -153,6 +158,7 @@ describe('E2E http-proxy-middleware', () => {
fixRequestBody(proxyReq, req);
},
},
logger: loggerSpy,
}),
),
);
Expand All @@ -173,6 +179,13 @@ describe('E2E http-proxy-middleware', () => {

expect(response.text).toContain('Error occurred while trying to proxy');
expect(targetSpy).toHaveBeenCalledTimes(0);
expect(loggerSpy.error).toHaveBeenCalledWith(
'[HPM] Error occurred while proxying request %s to %s [%s] (%s)',
expect.anything(),
expect.anything(),
'HPM_ERR_INVALID_MULTIPART_FIELD_VALUE',
'https://nodejs.org/api/errors.html#errors_common_system_errors',
);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
});
});

Expand Down
Loading