Skip to content

Adds ability to paginate using the pages API#19

Merged
Seenox merged 2 commits into
mainfrom
feat/paginate-by-page
Oct 18, 2022
Merged

Adds ability to paginate using the pages API#19
Seenox merged 2 commits into
mainfrom
feat/paginate-by-page

Conversation

@becelot

@becelot becelot commented Oct 18, 2022

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #19 (a7b91d6) into main (5faa450) will increase coverage by 0.04%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   86.32%   86.36%   +0.04%     
==========================================
  Files          26       26              
  Lines         870      873       +3     
==========================================
+ Hits          751      754       +3     
  Misses        119      119              
Flag Coverage Δ
unit 86.36% <27.27%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hostingde/dns/dns.py 40.62% <0.00%> (ø)
hostingde/domain/domain.py 51.28% <0.00%> (ø)
hostingde/hostingde.py 75.51% <0.00%> (ø)
hostingde/paginator.py 100.00% <100.00%> (ø)

@Seenox Seenox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Seenox Seenox merged commit 05b4d22 into main Oct 18, 2022
Seenox pushed a commit that referenced this pull request Oct 20, 2022
* Adds ability to paginate using the pages API (#19)

* feat: adds ability to paginate using the pages API which was originally hidden to the user

* chore: adds testcase for new paginator

* feat: adds None as possible chainable target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants