Skip to content

Support PHP 8 - #17

Merged
mpociot merged 2 commits into
beyondcode:masterfrom
mmachatschek:support_php8
Dec 18, 2020
Merged

Support PHP 8#17
mpociot merged 2 commits into
beyondcode:masterfrom
mmachatschek:support_php8

Conversation

@mmachatschek

@mmachatschek mmachatschek commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

This PR adds support for PHP 8

Solves #19

@justinhartman

Copy link
Copy Markdown

Please can this PR be merged into master? It's a simple fix for a solution that many of us need with PHP8 rolling out in full force now. I personally don't want to have to fork this repo just to make one change to composer.json as it seems redundant and unnecessary. pretty please 😄

@mmachatschek

Copy link
Copy Markdown
Contributor Author

@mpociot @sschlein little reminder if this PR can be merged?

@mpociot
mpociot merged commit 42bec87 into beyondcode:master Dec 18, 2020
@mpociot

mpociot commented Dec 18, 2020

Copy link
Copy Markdown
Member

Thanks for the reminder :)

@mmachatschek
mmachatschek deleted the support_php8 branch December 18, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants