Create snapshot from VM snapshot without memory for NFS/Local storage by slavkap · Pull Request #8117 · apache/cloudstack

slavkap · 2023-10-18T13:42:07Z

Description

This PR fixes #8078

The volume snapshot will be created only on secondary storage.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Hypervisor KVM
Primary storage NFS

take volume snapshot from VM snapshot without memory
create volume from that snapshot
crate template from the snapshot and deploy a VM

DaanHoogland

@slavkap, can you put the new/changed bits of code in new methods?
clgtm otherwise

DaanHoogland · 2023-10-18T14:34:24Z

@blueorangutan package

blueorangutan · 2023-10-18T14:36:03Z

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2023-10-18T14:58:22Z

Codecov Report

Merging #8117 (1c8cbc9) into 4.18 (0183e25) will increase coverage by 0.00%.
Report is 6 commits behind head on 4.18.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##               4.18    #8117   +/-   ##
=========================================
  Coverage     13.06%   13.06%           
- Complexity     9108     9110    +2     
=========================================
  Files          2720     2720           
  Lines        257531   257568   +37     
  Branches      40150    40154    +4     
=========================================
+ Hits          33655    33660    +5     
- Misses       219648   219677   +29     
- Partials       4228     4231    +3

Files	Coverage Δ
...tack/storage/motion/AncientDataMotionStrategy.java	`2.28% <0.00%> (-0.04%)`	⬇️
...om/cloud/storage/snapshot/SnapshotManagerImpl.java	`16.72% <35.00%> (+0.04%)`	⬆️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	`4.97% <0.00%> (-0.02%)`	⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-10-18T15:57:16Z

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6209

DaanHoogland · 2023-10-19T07:50:03Z

@blueorangutan test

blueorangutan · 2023-10-19T07:52:06Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr

Thanks @slavkap - didn't test it bu LGTM

blueorangutan · 2023-10-19T19:30:18Z

[SF] Trillian test result (tid-8009)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40457 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8009-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_vm_wrong_checksum	`Error`	39.60	test_templates.py
test_09_list_templates_download_details	`Failure`	0.04	test_templates.py

DaanHoogland · 2023-10-20T14:37:03Z

@slavkap is this ready? Can you add test info?

slavkap · 2023-10-23T05:57:26Z

@DaanHoogland, it's ready

yadvr · 2023-10-25T06:24:15Z

@blueorangutan package

blueorangutan · 2023-10-25T06:26:06Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-25T07:22:00Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7499

yadvr

LGTM, tested the following with local storage on adv zone kvm env:

create vm snapshot of a Ubuntu 22.04 VM with qemu-guest-agent running - pass
tested vm snapshot revert on a stopped VM - pass
created volume snapshot from VM snapshot - pass
created template from this volume snapshot in step-3 and deployed VM - pass

yadvr · 2023-10-25T09:28:40Z

@blueorangutan test matrix

blueorangutan · 2023-10-25T09:30:03Z

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2023-10-25T21:42:52Z

[SF] Trillian test result (tid-8090)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42411 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8090-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	681.68	test_kubernetes_clusters.py

blueorangutan · 2023-10-25T21:43:13Z

[SF] Trillian test result (tid-8088)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42553 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8088-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-10-25T23:35:41Z

[SF] Trillian test result (tid-8089)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49240 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8089-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…apache#8117) (cherry picked from commit 6ae3b73) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Create snapshot from VM snapshot for NFS/Local storage

80b87d7

boring-cyborg Bot added component:api component:kvm component:storage labels Oct 18, 2023

DaanHoogland approved these changes Oct 18, 2023

View reviewed changes

yadvr approved these changes Oct 19, 2023

View reviewed changes

yadvr added this to the 4.18.2.0 milestone Oct 19, 2023

yadvr requested a review from shwstppr October 20, 2023 09:36

extract changes in methods

1c8cbc9

yadvr approved these changes Oct 25, 2023

View reviewed changes

DaanHoogland merged commit 6ae3b73 into apache:4.18 Oct 26, 2023

shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023

Create snapshot from VM snapshot without memory for NFS/Local storage (…

a768c96

…apache#8117) (cherry picked from commit 6ae3b73) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conversation

slavkap commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

How Has This Been Tested?

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 18, 2023

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

codecov Bot commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 18, 2023

Uh oh!

DaanHoogland commented Oct 19, 2023

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 19, 2023

Uh oh!

DaanHoogland commented Oct 20, 2023

Uh oh!

slavkap commented Oct 23, 2023

Uh oh!

yadvr commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

yadvr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

blueorangutan commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

slavkap commented Oct 18, 2023 •

edited

Loading

codecov Bot commented Oct 18, 2023 •

edited

Loading

yadvr left a comment •

edited

Loading