ui: don't skip if dataview has multiple items in response

[yadvr]

This would fix the case of multiple items return in API response for a resource such as a template or ISO in case of multi-zone env.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[yadvr]

@blueorangutan ui

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[weizhouapache]

Verified OK on an environment with 2 zones

[nvazquez]

@rohityadavcloud could this fix cause regressions on PR #7846 which introduced the check?

[yadvr]

@nvazquez yes we need to regression test, but I think this code wasn't that useful in the first place; was put in as an additional check. We should check for #7846

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7947 (QA-JID-172)

[shwstppr]

code lgtm

[yadvr]

I've tested for #7846 and can't reproduce the issue with this fix, I think this PR should address @rajujith 's issue and not cause further regression. Thank @rajujith @weizhouapache for reporting.
/cc @weizhouapache @nvazquez

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[nvazquez]

Thanks @rohityadavcloud - LGTM

[codecov]

Codecov Report

Merging #7947 (b70641c) into 4.18 (57c61fb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7947      +/-   ##
============================================
- Coverage     13.06%   13.06%   -0.01%     
+ Complexity     9097     9096       -1     
============================================
  Files          2720     2720              
  Lines        257465   257465              
  Branches      40146    40146              
============================================
- Hits          33643    33634       -9     
- Misses       219594   219604      +10     
+ Partials       4228     4227       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6989

[weizhouapache]

Reproduced the issue and verified it is fixed by this PR.

Without this PR

With this PR

[rajujith]

The issue is no longer observed in environments with 2 zones.