Allow localhost hostnames for artifact checks - #1768
Merged
Conversation
robherley
force-pushed
the
robherley/artifacts-allow-localhost
branch
from
July 3, 2024 17:03
3d6d5e9 to
5683269
Compare
yacaovsnc
approved these changes
Jul 3, 2024
SrRyan
approved these changes
Jul 3, 2024
joshmgross
approved these changes
Jul 3, 2024
yaananth
approved these changes
Jul 3, 2024
luketomlinson
approved these changes
Jul 3, 2024
This was referenced Jul 5, 2024
shreck101
approved these changes
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces friction of local development by allowing
*.localhostdomains for hostname checks. These were failing fast by the GHES hostname checker.