Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix(v4-policy): add missing bucket field - #1168

Merged
frankyn merged 3 commits into
conformance-test-bucketfrom
v4-post-policy-sign-bucket
May 1, 2020
Merged

fix(v4-policy): add missing bucket field#1168
frankyn merged 3 commits into
conformance-test-bucketfrom
v4-post-policy-sign-bucket

Conversation

@jkwlui

@jkwlui jkwlui commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

fixes #1164

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2020
@jkwlui
jkwlui requested a review from frankyn April 27, 2020 23:04
@codecov

codecov Bot commented Apr 27, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (conformance-test-bucket@ea48df3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##             conformance-test-bucket    #1168   +/-   ##
==========================================================
  Coverage                           ?   99.19%           
==========================================================
  Files                              ?       12           
  Lines                              ?    11456           
  Branches                           ?      525           
==========================================================
  Hits                               ?    11364           
  Misses                             ?       92           
  Partials                           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea48df3...3cefae6. Read the comment docs.

Comment thread src/file.ts
@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 1, 2020
@jkwlui
jkwlui force-pushed the v4-post-policy-sign-bucket branch from 162173b to 3cefae6 Compare May 1, 2020 23:07
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 1, 2020
@frankyn
frankyn merged commit 555a950 into conformance-test-bucket May 1, 2020
@jkwlui
jkwlui deleted the v4-post-policy-sign-bucket branch May 1, 2020 23:43
frankyn pushed a commit that referenced this pull request May 4, 2020
* fix: sync to googleapis/conformance-tests@fa559a1

* fix: assert output fields

* run conformance-test after system-test

* run conformance-test via actions

* fix

* fix

* fix(v4-policy): add missing bucket field (#1168)

* fix(v4-policy): add missing bucket field

* remove bucket from fields

* fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants