Skip to content

fix(linter): add v7 of typescript-eslint to peerDeps - #21853

Merged
JamesHenry merged 1 commit into
nrwl:masterfrom
batazor:patch-1
Mar 6, 2024
Merged

fix(linter): add v7 of typescript-eslint to peerDeps#21853
JamesHenry merged 1 commit into
nrwl:masterfrom
batazor:patch-1

Conversation

@batazor

@batazor batazor commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Current Behavior

npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^6.13.2" from @nx/eslint-plugin@18.0.4
npm ERR! node_modules/@nx/eslint-plugin
npm ERR!   dev @nx/eslint-plugin@"*" from the root project

Expected Behavior

success migration to storybook@v8 and no problem with upgrade other deps

Related Issue(s)

Fixes #

@batazor
batazor requested a review from a team as a code owner February 16, 2024 21:01
@batazor
batazor requested a review from meeroslav February 16, 2024 21:01
@vercel

vercel Bot commented Feb 16, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 1:30pm

@batazor

batazor commented Feb 19, 2024

Copy link
Copy Markdown
Contributor Author

@meeroslav can you review this MR?

Comment thread packages/eslint-plugin/package.json Outdated
@seanparmelee

Copy link
Copy Markdown
Contributor

@meeroslav @JamesHenry @leosvelperez any chance one of ya'll could take a look at this one? Thanks in advance!

@seanparmelee

Copy link
Copy Markdown
Contributor

@batazor looks like the build is failing due to a commit message not following the convention: https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#commit-message-guidelines

@JamesHenry
JamesHenry enabled auto-merge (squash) March 6, 2024 13:29
@JamesHenry JamesHenry changed the title Fix peer-deps @typescript-eslint/parser fix(linter): add v7 of typescript-eslint to peerDeps Mar 6, 2024
@JamesHenry

Copy link
Copy Markdown
Contributor

I fixed up the commit message for you @batazor

@JamesHenry
JamesHenry merged commit 9194448 into nrwl:master Mar 6, 2024
@batazor
batazor deleted the patch-1 branch March 6, 2024 15:44
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2024
Co-authored-by: “JamesHenry” <james@henry.sc>
(cherry picked from commit 9194448)
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants