fix(remix): do not rename root jest.preset.js - #21703
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 65c5b64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
fix/remix-dont-rename-jestpreset
branch
2 times, most recently
from
February 8, 2024 14:04
d7d01e4 to
bc051f8
Compare
Coly010
force-pushed
the
fix/remix-dont-rename-jestpreset
branch
from
February 8, 2024 16:12
bc051f8 to
65c5b64
Compare
jaysoo
approved these changes
Feb 8, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit ec00acd)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When we generate a Remix application with --unitTestRunner=jest, it renames the root
jest.preset.jstojest.preset.cjs.This is required because Remix uses
type: modulein the package.json.However, multi-app repos will be impacted by renaming the root
jest.preset.js.Expected Behavior
We only need a
jest.preset.cjsfor standalone remix projectsRelated Issue(s)
Fixes #