fix(core): temporary use forked portable_pty to inherit cursor position for windows - #21683
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6405193. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
Cammisuli
marked this pull request as ready for review
February 7, 2024 19:52
Cammisuli
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
February 7, 2024 19:52
FrozenPandaz
approved these changes
Feb 7, 2024
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Some output on Windows becomes mangled because of ANSI codes that the Conpty adds.
Expected Behavior
Uses a forked portable_pty library to set the position of the cursor to inherit so that destructive ansi codes are not added.
Related Issue(s)
Fixes #