types: remove logic that omits timestamps when virtuals, methods, etc. options set - #15577
Merged
Conversation
…. options set Fix #12807
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the TypeScript logic that excluded timestamp inference when virtuals, methods, or statics options were set in Mongoose schemas. The change fixes issue #12807 by enabling proper type inference for schemas with timestamps alongside other schema options.
- Updates test to verify timestamp inference works with methods
- Removes outdated documentation about timestamp inference limitations
- Adds verification that both model properties and methods maintain correct typing
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/types/schema.test.ts | Updates type inference test to verify timestamps work with methods and adds model instantiation test |
| docs/typescript/schemas.md | Removes documentation about timestamp inference limitation with methods/virtuals/statics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12807
Summary
Looks like the original issue from #12807 just went away, either due to a recent TypeScript release or some other fix we did. This fix would have still worked in 8.17.0, but not 8.16.0
Examples