Skip to content

worker: use DataCloneError for unknown native objects#28025

Closed
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:message-native-datacloneerror
Closed

worker: use DataCloneError for unknown native objects#28025
addaleax wants to merge 2 commits into
nodejs:masterfrom
addaleax:message-native-datacloneerror

Conversation

@addaleax

@addaleax addaleax commented Jun 2, 2019

Copy link
Copy Markdown
Member

This aligns the behaviour better with the web.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This aligns the behaviour better with the web.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Jun 2, 2019
Comment thread src/env.h
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment thread test/parallel/test-worker-message-port-transfer-native.js Outdated
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleax

Copy link
Copy Markdown
Member Author

Landed in 7bd2a3f

@addaleax addaleax closed this Jun 10, 2019
@addaleax addaleax deleted the message-native-datacloneerror branch June 10, 2019 13:38
addaleax added a commit that referenced this pull request Jun 10, 2019
This aligns the behaviour better with the web.

PR-URL: #28025
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
This aligns the behaviour better with the web.

PR-URL: #28025
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants