Repository navigation
Fix worker crash from bad socket client - #246
Merged
Merged
Conversation
This bug fixes a problem caused by a socket client quickly disconnecting after requesting 'data' from a worker socket. I have so far been unable to track down what has been causing this bad client behavior, but it seems sensible that a socket client should not be able to crash a worker like this, so I hope this gets merged.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug fixes a problem caused by a socket client quickly disconnecting
after requesting 'data' from a worker socket. I have so far been unable
to track down what has been causing this bad client behavior, but it
seems sensible that a socket client should not be able to crash a worker
like this, so I hope this gets merged.