layout: Implement the correct behavior for block formatting contexts adjacent to floats per CSS 2.1 § 9.5. - #1734
Closed
pcwalton wants to merge 2 commits into
Closed
Conversation
|
|
|
Critic review: https://critic.hoppipolla.co.uk/r/857 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Contributor
Author
|
Blogged on how this works: http://pcwalton.github.io/blog/2014/02/25/revamped-parallel-layout-in-servo/ |
Contributor
Author
|
New version of the patch unbreaks Wikipedia and is based on top of the float context rewrite. r? @kmcallister |
`clear` or by establishing a block formatting context) that they are unaffected by floats. This results in a 2.78x parallel speedup over sequential on the attached test case, `perf-acid1.html`.
adjacent to floats per CSS 2.1 § 9.5. Results in an 80% parallel improvement on YouTube.
Contributor
Author
|
Superseded by #2256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results in an 80% parallel improvement over sequential on youtube.com.
This is quite tricky—it involves a sea change to layout in order to make block layout interruptible and resumable, and intertwines assign-widths and assign-heights even more—and I'd be happy to go over this via video or IRC.
r? @larsbergstrom