Handle upcasting and downcasting of JSON schemas with type arrays#1820
Merged
MaggieKimani1 merged 7 commits intoOct 2, 2024
Conversation
darrelmiller
requested changes
Sep 10, 2024
darrelmiller
left a comment
Member
There was a problem hiding this comment.
I think if you remove the code that removes the x-nullable this PR looks good.
darrelmiller
approved these changes
Sep 30, 2024
darrelmiller
left a comment
Member
There was a problem hiding this comment.
This looks good. Although we should add a test case for when someone provides type as an array and also provides the nullable keyword. It should never happen but the current code would fail if it does.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1786