sending SIGINT or EOF gives unexpected results in node REPL #955

Activity

1. isaacs commented on Apr 20, 2011

   

   isaacs

   on Apr 20, 2011

   More actions

   I'm +1 to this. ^C should be "break" only, and not "exit", imo.

   @ry how do you feel about this?
2. ry commented on Apr 20, 2011

   

   ry

   on Apr 20, 2011

   More actions

   i'm for it
3. TooTallNate commented on Apr 20, 2011

   

   TooTallNate

   on Apr 20, 2011

   More actions

   Yes! I was just thinking this exact thing the other day
4. isaacs

   closed this as completedin 0b3ecc0on Apr 21, 2011
5. jnjackins

   reopened this on Apr 26, 2011
6. jnjackins commented on Apr 26, 2011

   

   jnjackins

   on Apr 26, 2011

   Author

   More actions

   This seems to work now, but I think I found a bug:

   $ node
   > user = require('./user');
   
   /.../user.js:52
     console.log(User(email, pw);
                            ^
   ... ^C$ (REPL has exited and I'm back at my shell)
   

   I'm trying to require a module which has a syntax error it. It shows the error message and an ellipses (...). If I press enter, the error message is displayed again. If I press ^D, the REPL exits (this is somewhat unexpected since I'm not on an empty input line). If I press ^C, the REPL exits. I tried reproducing this by typing only the syntactically wrong line of code (without doing a require) but in that case things seemed to work properly.
7. jnjackins commented on Apr 26, 2011

   

   jnjackins

   on Apr 26, 2011

   Author

   More actions

   further, just doing this:

   > require('./mylocalmodule');
   

   results in more weird behavior. On the input line that comes up after that require statement, ^D does nothing and ^C exists the program.
8. jnjackins commented on Apr 26, 2011

   

   jnjackins

   on Apr 26, 2011

   Author

   More actions

   ok, so I tried this with a few different local modules, and the problem in my latter comment doesn't occur for all local modules, but I can reproduce it by requiring a file containing this:

   var redis = require('redis'),
       client = redis.createClient();
   
   exports.getUser = function (email, callback) {
     client.get(email, callback);
   }
   

   after requiring this module, typing something and then pressing ^C actually does works as expected. However, pressing ^D seems to cause the REPL to hang, so that it isn't catching any subsequent SIGINTs. That's why ^C was closing the program in my comment above, I was pressing ^D first.

   EDIT: the first problem doesn't seem to be related to the second problem, I can reproduce the first problem when requiring a file which doesn't have the second problem.
9. sh1mmer commented on Oct 24, 2011

   

   sh1mmer

   on Oct 24, 2011

   More actions

   @jnjackins please create a new bug for the second problem rather than reopening a fixed issue.
10. bnoordhuis

    closed this as completedon Mar 27, 2012