Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

fs.mkdir / fs.mkdirSync - mode parameter #1999

Closed

Description

@Bonuspunkt

mode is ignored on windows, so it should be a optional parameter / have a default value

>node -v
v0.5.10

>node --eval "require('fs').mkdirSync('newDir')"

fs.js:361
  return binding.mkdir(path, modeNum(mode));
                 ^
TypeError: Bad argument
    at Object.mkdirSync (fs.js:361:18)
    at Object. (eval at  (eval:1:75))
    at Object. (eval:1:63)
    at Module._compile (module.js:432:26)
    at startup (node.js:84:14)
    at node.js:534:3

Activity

  1. added a commit that references this issue on Nov 3, 2011
    11d68eb
  2. bnoordhuis commented on Nov 3, 2011

    @bnoordhuis
    Member

    bnoordhuis/node@11d68eb - review anyone?

  3. koichik commented on Nov 3, 2011

    @koichik

    @bnoordhuis - LGTM.

  4. bnoordhuis commented on Nov 3, 2011

    @bnoordhuis
    Member

    @koichik: Thanks! Merged in 11d68eb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions