This repository was archived by the owner on Mar 9, 2026. It is now read-only.
test: Fix test failures due to grpcio changes - #1178
Merged
Merged
Conversation
mukund-ananthu
force-pushed
the
fixK
branch
4 times, most recently
from
May 29, 2024 19:48
272e34e to
b959dd1
Compare
mukund-ananthu
force-pushed
the
fixK
branch
4 times, most recently
from
May 29, 2024 20:03
608092f to
2dc559c
Compare
mukund-ananthu
force-pushed
the
fixK
branch
3 times, most recently
from
May 29, 2024 20:44
ee9c76a to
1e4efdc
Compare
mukund-ananthu
enabled auto-merge (squash)
May 29, 2024 20:48
* Failures can be found in googleapis/python-api-common-protos#223
parthea
approved these changes
May 30, 2024
Comment on lines
+136
to
+141
| # Behavior to include dns prefix changed in gRPCv1.63 | ||
| grpc_major, grpc_minor = [int(part) for part in grpc.__version__.split(".")[0:2]] | ||
| if grpc_major > 1 or (grpc_major == 1 and grpc_minor >= 63): | ||
| _EXPECTED_TARGET = "dns:///testendpoint.google.com:443" | ||
| else: | ||
| _EXPECTED_TARGET = "testendpoint.google.com:443" |
Contributor
There was a problem hiding this comment.
This could be moved to a help function to avoid duplication. I'll go ahead and approve since the builds are failing at main but consider creating a follow up PR to reduce code duplication.
This was referenced Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1177 🦕