diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java index 9d687bb5168..c177f91edf0 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractReadContext.java @@ -794,8 +794,7 @@ CloseableIterator startStream(@Nullable ByteString resumeToken return stream; } }; - GrpcResultSet resultSet = new GrpcResultSet(stream, this); - return resultSet; + return new GrpcResultSet(stream, this); } private Struct consumeSingleRow(ResultSet resultSet) { diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java index 56cd1af47e9..00391447d90 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java @@ -208,7 +208,7 @@ protected com.google.protobuf.Value computeNext() { Object merged = kind == KindCase.STRING_VALUE ? value.getStringValue() - : new ArrayList(value.getListValue().getValuesList()); + : new ArrayList<>(value.getListValue().getValuesList()); while (current.getChunkedValue() && pos == current.getValuesCount()) { if (!ensureReady(StreamValue.RESULT)) { throw newSpannerException( diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java index 1ae353c0027..501ae054e9f 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AsyncResultSet.java @@ -39,9 +39,8 @@ enum CursorState { * Non-blocking call that attempts to step the cursor to the next position in the stream. The * cursor may be inspected only if the cursor returns {@code CursorState.OK}. * - *

A caller will typically call {@link #tryNext()} in a loop inside the ReadyCallback, - * consuming all results available. For more information see {@link #setCallback(Executor, - * ReadyCallback)}. + *

A caller will typically call tryNext in a loop inside the ReadyCallback, consuming all + * results available. For more information see {@link #setCallback(Executor, ReadyCallback)}. * *

Currently this method may only be called if a ReadyCallback has been registered. This is for * safety purposes only, and may be relaxed in future. @@ -146,8 +145,8 @@ interface ReadyCallback { *