This repository was archived by the owner on Mar 23, 2026. It is now read-only.
feat: add support for DecimalTargetTypes - #1345
Merged
stephaniewang526 merged 5 commits intoJun 8, 2021
Merged
Conversation
Towards b/188414733 Implemented in LoadJobConfiguration
stephaniewang526
marked this pull request as draft
June 2, 2021 18:18
stephaniewang526
marked this pull request as ready for review
June 7, 2021 16:23
MingyuZhong
reviewed
Jun 7, 2021
MingyuZhong
approved these changes
Jun 7, 2021
shollyman
approved these changes
Jun 8, 2021
shollyman
left a comment
Contributor
There was a problem hiding this comment.
Nice, I like the exercise of the precision/scale validation in the integration test.
Contributor
Author
|
Will not merge until the UI change reaches golden. |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.133.0](https://www.github.com/googleapis/java-bigquery/compare/v1.132.1...v1.133.0) (2021-06-08) ### Features * add support for DecimalTargetTypes ([#1345](https://www.github.com/googleapis/java-bigquery/issues/1345)) ([ba528df](https://www.github.com/googleapis/java-bigquery/commit/ba528df03def71907e2811cf267718f090605d95)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigtable to v1.26.1 ([#1360](https://www.github.com/googleapis/java-bigquery/issues/1360)) ([bf55699](https://www.github.com/googleapis/java-bigquery/commit/bf55699d849de7e873577de04e44fbfe0f078ab1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/188414733
Implemented in LoadJobConfiguration and ExternalTableDefinition
cc @MingyuZhong