fix(spanner): use spanner options when initializing monitoring exporter - #11109
Merged
Conversation
olavloite
reviewed
Nov 10, 2024
olavloite
left a comment
Contributor
There was a problem hiding this comment.
The change LGTM, but can we add a test that fails without this change, and succeeds with it? Or is that for some reason not possible?
rahul2393
force-pushed
the
use-spanner-opts-in-monitoring
branch
from
November 12, 2024 07:27
02f989c to
0903a4a
Compare
olavloite
approved these changes
Nov 12, 2024
rahul2393
force-pushed
the
use-spanner-opts-in-monitoring
branch
from
November 12, 2024 16:44
c13b30f to
3b31f22
Compare
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
🤖 I have created a release *beep* *boop* --- ## [1.73.0](https://togithub.com/googleapis/google-cloud-go/compare/spanner/v1.72.0...spanner/v1.73.0) (2024-11-14) ### Features * **spanner:** Add ResetForRetry method for stmt-based transactions ([#10956](https://togithub.com/googleapis/google-cloud-go/issues/10956)) ([02c191c](https://togithub.com/googleapis/google-cloud-go/commit/02c191c5dc13023857812217f63be2395bfcb382)) ### Bug Fixes * **spanner:** Add safecheck to avoid deadlock when creating multiplex session ([#11131](https://togithub.com/googleapis/google-cloud-go/issues/11131)) ([8ee5d05](https://togithub.com/googleapis/google-cloud-go/commit/8ee5d05e288c7105ddb1722071d6719933effea4)) * **spanner:** Allow non default service account only when direct path is enabled ([#11046](https://togithub.com/googleapis/google-cloud-go/issues/11046)) ([4250788](https://togithub.com/googleapis/google-cloud-go/commit/42507887523f41d0507ca8b1772235846947c3e0)) * **spanner:** Use spanner options when initializing monitoring exporter ([#11109](https://togithub.com/googleapis/google-cloud-go/issues/11109)) ([81413f3](https://togithub.com/googleapis/google-cloud-go/commit/81413f3647a0ea406f25d4159db19b7ad9f0682b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #11080 (comment)