Improve performance of SQL strings in ExecuteQuery/ExecuteStatement functions

[LalitMaganti]

There's a bunch of string copying and substrings happening which are largely unnecessary and can be removed. On the first hand, we should really trying to be using string views where possible. On the second hand, we should move this replacement down into the engine/SqlSource.

On the third hand, SqlSource itself should probably go away and be replaced by syntaqlite error tracking so that's there as well.

[KaustAbhinand]

Hello! I would like to work on this issue, could you please assign it to me?

[LalitMaganti]

Hi. I don't think this issue can be fixed without first discussing a little what fix you have in mind. As I said there are multiple options for "fixing" here. What are you planning?

[KaustAbhinand]

Hello! I think the second option would be the easiest one to implement, as we are moving the replacement in the existing code.

For the first option, we would have to change all the existing strings to string views, and the third, it would mean a complete change in the project, as we are migrating to syntaqlite.

[LalitMaganti]

I think it might be tricker than you think but I'm willing to take a look if you want to try it. Not guaranteeing this is going to go in though, I can easily see this getting quite complicated unless you understand the code deeply.

[KaustAbhinand]

Thanks for assigning the issue, i will of course try my best, if i encounter any difficulties, i will reach out to you.