Skip to content

Basic rest api#1

Merged
roznawsk merged 20 commits into
mainfrom
basic-rest-api
Sep 11, 2023
Merged

Basic rest api#1
roznawsk merged 20 commits into
mainfrom
basic-rest-api

Conversation

@roznawsk

@roznawsk roznawsk commented Sep 7, 2023

Copy link
Copy Markdown
Member

No description provided.

@roznawsk roznawsk requested a review from LVala September 7, 2023 14:54
@roznawsk roznawsk marked this pull request as ready for review September 7, 2023 14:54
@roznawsk roznawsk requested a review from sgfn September 7, 2023 14:55

@sgfn sgfn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice codec in tests

Comment thread generate_client.sh
Comment thread generate_client.sh Outdated
Comment thread generate_client.sh
Comment thread openapi/openapi_client/__init__.py Outdated
Comment thread jellyfish/room_api.py
Comment thread jellyfish/room_api.py
Comment thread jellyfish/room_api.py Outdated
Comment thread openapitools.json

@LVala LVala left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for things mentioned by @sgfn, I don't see anything particularly wrong, Python isn't my forte tho.

@sgfn sgfn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@roznawsk roznawsk merged commit 6ca6f3e into main Sep 11, 2023
@roznawsk roznawsk deleted the basic-rest-api branch September 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants