Skip to content

fix(messaging,macos): fix an issue where getInitialMessage could hang forever in macOS - #18457

Merged
Lyokone merged 1 commit into
mainfrom
fix/11014
Jul 17, 2026
Merged

fix(messaging,macos): fix an issue where getInitialMessage could hang forever in macOS#18457
Lyokone merged 1 commit into
mainfrom
fix/11014

Conversation

@Lyokone

@Lyokone Lyokone commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

On macOS, plugin registration could occur after the application-finished-launching notification, leaving getInitialMessage() waiting forever because native notification setup never ran. This initializes late registrations immediately, safely extracts macOS launch notification data, and retains the first notification response as the initial message.

Related Issues

Verification

  • flutter test in packages/firebase_messaging/firebase_messaging
  • Analyze firebase_messaging_e2e_test.dart
  • flutter build macos
  • flutter build ios --simulator --no-codesign
  • Run the macOS integration test; its host currently fails to build because the Firebase Messaging SPM target cannot find PrivacyInfo.xcprivacy.
  • Confirm a terminated-state notification launch on macOS returns the initial message.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone merged commit 87d88d2 into main Jul 17, 2026
64 of 67 checks passed
@Lyokone
Lyokone deleted the fix/11014 branch July 17, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_messaging] getInitialMessage() does not terminate on macOS if app starts from terminated state

3 participants