fix(firebase_messaging): fix null apple notification when sound is of type String - #17770
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
Hi @abdalin, thanks for the contribution. LGTM! |
fixed notification sound being null in notification.apple.sound of onMessage stream
Description
If a notification is sent from backend with a sound file String, the sound value in RemoteMessage.notification.apple.sound is being received as null in FirebaseMessaging.onMessage stream of Flutter interface. That was because sound was incorrectly being assigned to notification instead of notificationIOS in FLTFirebaseMessagingPlugin implementation of iOS.
Related Issues
None
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?