Skip to content

fix(auth, android): signInWithProvider() for non-default instances - #13522

Merged
russellwheatley merged 4 commits into
firebase:mainfrom
Navideck:feat(auth)-support-signInWithProvider-for-non-default-instances
Nov 19, 2024
Merged

fix(auth, android): signInWithProvider() for non-default instances#13522
russellwheatley merged 4 commits into
firebase:mainfrom
Navideck:feat(auth)-support-signInWithProvider-for-non-default-instances

Conversation

@rohitsangwan01

Copy link
Copy Markdown
Contributor

Description

This PR fixes the use of signInWithProvider for Firebase Auth instances that are not the default instance in Android

Previously, attempting to use signInWithProvider with a non-default instance would result in unexpected behaviour. This change ensures that the correct Firebase Auth instance is used when calling signInWithProvider, regardless of whether it is the default instance or not.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitsangwan01 - You just need to run melos run format-ci and this LGTM

@rohitsangwan01

Copy link
Copy Markdown
Contributor Author

@russellwheatley Done

@russellwheatley

russellwheatley commented Nov 19, 2024

Copy link
Copy Markdown
Member

@russellwheatley russellwheatley changed the title feat(auth): Support signInWithProvider for non-default instances feat(auth, android): Support signInWithProvider for non-default instances Nov 19, 2024
@russellwheatley russellwheatley changed the title feat(auth, android): Support signInWithProvider for non-default instances fix(auth, android): signInWithProvider() for non-default instances Nov 19, 2024
@russellwheatley
russellwheatley merged commit f25e21c into firebase:main Nov 19, 2024
@firebase firebase locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants