Remove the FCM Direct Channel API from Messaging - #6430
Merged
Conversation
charlotteliang
requested review from
gsakakihara,
morganchen12,
paulb777 and
ryanwilson
September 9, 2020 22:52
morganchen12
reviewed
Sep 9, 2020
paulb777
reviewed
Sep 9, 2020
paulb777
left a comment
Member
There was a problem hiding this comment.
Great to see much code deletion!
Please fix the GHA failures.
ryanwilson
approved these changes
Sep 11, 2020
ryanwilson
left a comment
Member
There was a problem hiding this comment.
😍 amazing, I didn't know there was this much red in the whole galaxy!
| @@ -57,41 +57,6 @@ typedef void (^FIRMessagingDeleteFCMTokenCompletion)(NSError *_Nullable error) | |||
| typedef void (^FIRMessagingTopicOperationCompletion)(NSError *_Nullable error); | |||
|
|
|||
| #if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0 | |||
Member
There was a problem hiding this comment.
This conditional can be cleared as well for a nicer cleanup - I think this was obsolete once we started requiring Xcode 8 😝 Just for a follow up PR - no need to do it here
morganchen12
approved these changes
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated FCM direct channel and Upstream Send from Messaging. This includes the API, code and tests.
This also removes protocol buffer dependency.
Fixed #5216.