Skip to content

Add support for the new FCM registration ID. - #16133

Merged
morganchen12 merged 57 commits into
mainfrom
fid
Jun 30, 2026
Merged

Add support for the new FCM registration ID.#16133
morganchen12 merged 57 commits into
mainfrom
fid

Conversation

@leojaygoogle

@leojaygoogle leojaygoogle commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

This is to integrate with the new V1 Registration API go/android-gmi-v1-registration-api

It defaults to NO. When enabled, FCM will not generate an FCM registration token, but an FID instead.
…anagement system.

Currently, the FCM SDK calls the `https://fcmtoken.googleapis.com/register` backend to register an FCM V4 registration token. Going forward, we'd like to deprecate this token and use FID instead.
Once `unregister()` is called successfully and auto-init is disabled, Sending a push notification to the FID will result in an `UNREGISTERED` error.
This method is similar to `messaging(_:didReceiveRegistrationToken:)`, but will be called instead when `isInstallationIdEnabled` is `YES`.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated

@Doris-Ge Doris-Ge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does our existing implementation listen for a FID change via a listener and re-register on a change? If not, we may want to add that.

I'm still reviewing the PR, but I'd like to give some early feedback in case you want to address or discuss it. Since I'm not familiar with Swift, I need more time for a full review. Sorry about that!

Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/FIRMessaging.m
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/FIRMessaging.m Outdated
Comment thread FirebaseMessaging/Sources/FIRMessaging.m
Comment thread FirebaseMessaging/Sources/Token/FIRMessagingFIDRegisterOperation.m
Comment thread FirebaseMessaging/Sources/FIRMessaging.m Outdated
It tests that when `FirebaseMessaging.isInstallationIdEnabled` is `YES`, calling `register()` triggers a V1 registration API HTTP request. After receiving the registered FID, the message delegate's `didReceiveRegistration` should be called.
…register`.

So that it doesn't depend on the `register` being called.
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
Comment thread FirebaseMessaging/CHANGELOG.md Outdated
Comment thread FirebaseMessaging/CHANGELOG.md Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <p> tags can be removed. A paragraph should render properly without them.

Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h Outdated
@ncooke3 ncooke3 added this to the 12.16.0 - M183 milestone Jun 30, 2026
leojaygoogle and others added 2 commits June 30, 2026 12:44
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
Comment thread FirebaseMessaging/Sources/Public/FirebaseMessaging/FIRMessaging.h
@leojaygoogle
leojaygoogle enabled auto-merge (squash) June 30, 2026 21:37
leojaygoogle and others added 2 commits June 30, 2026 14:46
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
@paulb777
paulb777 disabled auto-merge June 30, 2026 23:06
@morganchen12
morganchen12 merged commit d9fc76a into main Jun 30, 2026
75 of 76 checks passed
@morganchen12
morganchen12 deleted the fid branch June 30, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants