Skip to content

feat: adds domain endpoints#16

Merged
Seenox merged 4 commits into
mainfrom
feat/domains
Oct 4, 2022
Merged

feat: adds domain endpoints#16
Seenox merged 4 commits into
mainfrom
feat/domains

Conversation

@becelot

@becelot becelot commented Oct 4, 2022

Copy link
Copy Markdown
Member

Closes #15

This is the initial implementation for domains endpoints. This MR provides the bare minimum endpoints to be able to implement a domain registration.

@codecov

codecov Bot commented Oct 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16 (09f5bbd) into main (575741c) will decrease coverage by 1.14%.
The diff coverage is 85.24%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   87.73%   86.58%   -1.15%     
==========================================
  Files          23       25       +2     
  Lines         693      835     +142     
==========================================
+ Hits          608      723     +115     
- Misses         85      112      +27     
Flag Coverage Δ
unit 86.58% <85.24%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hostingde/account/account.py 63.15% <20.00%> (-15.42%) ⬇️
hostingde/dns/dns.py 40.62% <20.00%> (-1.75%) ⬇️
hostingde/job_waiter.py 52.00% <20.00%> (-9.91%) ⬇️
hostingde/domain/domain.py 56.66% <56.66%> (ø)
hostingde/model/account.py 76.19% <81.81%> (+3.46%) ⬆️
hostingde/client.py 100.00% <100.00%> (ø)
hostingde/domain/requests/register_domain.py 100.00% <100.00%> (ø)
hostingde/exceptions.py 70.00% <100.00%> (+7.50%) ⬆️
hostingde/model/domain.py 100.00% <100.00%> (ø)
hostingde/model/domain_contact.py 100.00% <100.00%> (ø)
... and 3 more

@becelot becelot requested a review from Seenox October 4, 2022 16:02

@Seenox Seenox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Seenox Seenox merged commit afb488b into main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for domain endpoints

2 participants