[BUG] Keka failed to extract a specified zip file

[KLszTsu]

Configuration

• Keka version: 1.2.15 (4583)
• macOS version: 11.4 (20F71)

Describe the bug

Keka failed to extract a specified zip file. The link to the file is provided below.

To Reproduce

Steps to reproduce the behavior:

1. Go to this link, press the download link at the top of the page to download the zip file.
2. Extract the zip file with Keka and run it.

What has happened:

Finder says "SpyderXPro_5.8.pkg" is damaged and can't be opened. You should move it to the Bin.

log:

2021-06-29 17:20:59.454 Dev mode enabled
2021-06-29 17:20:59.455 Running on OS X/macOS version 11.4 (Build 20F71)
2021-06-29 17:20:59.455 Running sandboxed Keka (WEB) version 1.2.15 (4583)
2021-06-29 17:20:59.455 Used localization: en-GB
2021-06-29 17:20:59.519 DEV: Adding 1 files
2021-06-29 17:20:59.519 DEV: Waiting for more input: 0.250000
2021-06-29 17:20:59.520 DEV: Requesting access to all bookmarks
2021-06-29 17:20:59.520 DEV: Bookmarks updated: 3
2021-06-29 17:20:59.525 DEV: Ignoring bookmarked external path "/Volumes/fakepath" since it's not currently available (0)
2021-06-29 17:20:59.526 Bookmark is stale, removing it: /private/tmp/test
2021-06-29 17:20:59.526 DEV: Bookmarks updated: 2
2021-06-29 17:20:59.527 Can't start bookmark access: /private/tmp/test
2021-06-29 17:20:59.803 DEV: No bookmarked file access...
2021-06-29 17:21:00.301 DEV: Dismissing delayed tasks
2021-06-29 17:21:03.095 DEV: Bookmarks updated: 3
2021-06-29 17:21:03.097 DEV: Checking tasks queue
2021-06-29 17:21:03.127 DEV: Starting queued task
2021-06-29 17:21:03.128 DEV: Path set as unavailable: /private/tmp/IR24/SpyderXPro_5.8.pkg.kextraction
2021-06-29 17:21:03.131 DEV: OS: Version 11.4 (Build 20F71)
2021-06-29 17:21:03.131 DEV: Keka: v1.2.15-r4583 (WEB) (Sandboxed) (en-GB)
2021-06-29 17:21:03.131 DEV: Format detected: ZIP
2021-06-29 17:21:03.131 DEV: Binary used: kekaunar
2021-06-29 17:21:03.131 DEV: Arguments: (
    "-q",
    "-r",
    "-K",
    "-nq",
    "-o",
    "/private/tmp/IR24/SpyderXPro_5.8.pkg.kextraction/Operation",
    "/private/tmp/IR24/SpyderXPro_5.8.pkg.zip"
)
2021-06-29 17:21:03.630 DEV: Checking ended task
2021-06-29 17:21:03.631 DEV: Quarantine apply starting...
2021-06-29 17:21:03.645 DEV: {
    LSQuarantineAgentBundleIdentifier = "org.mozilla.firefox";
    LSQuarantineAgentName = Firefox;
    LSQuarantineDataURL = "https://d3d9ci7ypuovlo.cloudfront.net/spyderx/SpyderXPro_5.8.pkg.zip";
    LSQuarantineEventIdentifier = "AF91EF82-CABD-432F-8F37-55625039C5BB";
    LSQuarantineIsOwnedByCurrentUser = 1;
    LSQuarantineOriginURL = "https://support.datacolor.com/index.php?/Knowledgebase/Article/View/1835/159/spyderx-pro-58-macos";
    LSQuarantineTimeStamp = "2021-06-29 17:03:33 +0000";
    LSQuarantineType = LSQuarantineTypeWebDownload;
}
2021-06-29 17:21:03.647 DEV: Quarantine apply done
2021-06-29 17:21:03.647 DEV: Checking tasks queue
2021-06-29 17:21:03.651 DEV: Path set as unavailable: /private/tmp/IR24/SpyderXPro_5.8.pkg
2021-06-29 17:21:03.652 DEV: Path already set as unavailable: /private/tmp/IR24/SpyderXPro_5.8.pkg
2021-06-29 17:21:03.652 DEV: Path set as available: /private/tmp/IR24/SpyderXPro_5.8.pkg
2021-06-29 17:21:03.652 DEV: Path set as available: /private/tmp/IR24/SpyderXPro_5.8.pkg.kextraction
2021-06-29 17:21:03.653 DEV: (
    "OS: Version 11.4 (Build 20F71)",
    "Keka: v1.2.15-r4583 (WEB) (Sandboxed) (en-GB)",
    "Format detected: ZIP",
    "Binary used: kekaunar",
    "Arguments: (\n    \"-q\",\n    \"-r\",\n    \"-K\",\n    \"-nq\",\n    \"-o\",\n    \"/private/tmp/IR24/SpyderXPro_5.8.pkg.kextraction/Operation\",\n    \"/private/tmp/IR24/SpyderXPro_5.8.pkg.zip\"\n)"
)
2021-06-29 17:21:03.659 DEV: Stopping access to all bookmarks
2021-06-29 17:21:03.660 DEV: Ignoring bookmarked external path "/Volumes/fakepath" since it's not currently available

What should happen:

Keka should be able to extract this zip file correctly.

Additional Info

• I also try to use the unzip command (UnZip) to extract the file, which works perfectly fine and I'm able to open the SpyderXPro 5.8.pkg. An information is that unzip created the filename SpyderXPro 5.8.pkg instead of SpyderXPro_5.8.pkg
• Please note that this file contains a proprietary software developed by datacolor™, and by visiting the website, or downloading the software, you agree to be bound by datacolor's Terms of Use.

Yours faithfully.

[aonez]

Thanks for the feedback @KLszTsu! I can't reproduce the issue, is extracting properly in Big Sur 11.4, downloaded from Safari or Firefox. Even in /private/tmp/ path.

Could you try extracting the file to another destination, like the Desktop?

If still fails, please quit Keka, remove the preferences by executing rm -r ~/Library/Containers/com.aone.keka and try again.

Let me know how it goes :)

[KLszTsu]

Hi @aonez , after spending some time on the problem, I find the reason.

Unzip unzip the file directly to the working directory (pwd) without creating a folder to contain the file, but Keka will create a folder and put the extracted file inside.
So after Keka's extraction, we have something like this:

fakeuser@FakeComputer fakepath % ls -FR . 
SpyderXPro_5.8.pkg/	SpyderXPro_5.8.pkg.zip

./SpyderXPro_5.8.pkg:
SpyderXPro 5.8.pkg

As the folder Keka created to contain the extracted file has a .pkg extension, Mac recognize it to be a Package, so when I double clicked the extracted "Package" to run the installer, it failed. But instead I should get inside the folder and double click the real Package to install.

->

So in the end this is not Keka's fault :)
But this situation is really confusing for the user. I don't know if anything could be done, but you can close this issue if you want :D

->

Thank you for making this wonderful software!

Yours sincerely.

[KLszTsu]

I'm thinking about if really anything could be done, for example, don't create subfolder if the resulting filename for the subfolder is a Mac Package, even with the "Always extract in a subfolder" selected, or create subfolder without the Mac Package extension so that it won't be misinterpreted as a Mac Package.

Either way, this introduce an inconsistency in the design to say the least, and potentially many problem to arise later.

[aonez]

Thanks a lot for the extensive testing @KLszTsu! Indeed this should and can be fixed. I'm renaming the extension like this:

• Current behavior:file.pkg.7z results in intermediate folder file.pkg
• New behavior:file.pkg.7z results in intermediate folder file_pkg

This will be used for any extension (.wathever), because the number of bundle extensions (.app, .pkg, .kext...) is large and also third party extensions can be used, so that way the fix will be always working.

Here a test build: https://d.keka.io/test/Keka-1.2.16.r4589

[KLszTsu]

Wow this is amazing! Thank you!

Although a small bug is that it seems to have some trouble handling archive name with space in it?
For example, Te st.app.7z.