Unbreak CI: PHPStan false positive and matrix fail-fast

[georgestephanis]

Why

Every pull request currently looks broken, and for reasons that have nothing to do with the code being proposed. This fixes the workflow itself.

PHPStan was the fourth cause, but #972 handles that one properly — by upgrading PHPStan and dropping includes/ from the analysed paths, matching the */includes/* exclusion that already exists in phpcs.xml.dist. That's a better fix than the scoped ignore this PR originally carried, so it has been removed here. This PR is now purely workflow changes; #972 keeps the PHPStan fix.

The two are complementary. #972 can't go green on its own — its only failing leg is Test PHP 7.4, with the other 27 cancelled, which is exactly what's fixed below. Landing this first should unblock it.

What

1. One failing leg no longer cancels the other 27

The matrix ran with the default fail-fast: true. A single failure cancelled every other job, so 28 jobs reported as 1 failure + 27 cancelled and nothing usable came back. Now fail-fast: false.

2. PHP 7.4 and 8.0 removed from the matrix

These cannot be run any more, and it isn't a transient breakage.

wp-env builds its container from wordpress:php<version>, and:

Tag	Last rebuilt	Base
wordpress:php7.4-fpm	2022-11-16	bullseye
wordpress:php8.0-fpm	2023-11-22	bullseye
wordpress:php8.1-fpm	2026-01-01	bookworm
wordpress:php8.4-fpm	2026-08-31	bookworm

Debian bullseye LTS ended 2026-08-31. Its security Release file is now expired, so the apt-get -qy update in wp-env's generated Dockerfile exits 100 before a single test runs. No bookworm image exists for 7.4 or 8.0 — both reached EOL before bookworm shipped — and wp-env hardcodes both the base image (lib/runtime/docker/docker-config.js:83) and that apt call (line 167), with no configuration hook for either. Verified against wp-env 11.14.0; this repo pins ^10.30.0.

8.1 is bookworm and passes, so it becomes the lowest version actually exercised.

Note: PHP 7.4 is still the declared minimum (Requires PHP in two-factor.php, >=7.4 in composer.json). It stays covered statically by PHPCompatibilityWP via testVersion 7.4-, but it is no longer exercised at runtime. Whether to raise the floor to 8.1 is a support-policy decision and deliberately isn't made here.

3. The suite ran twice for every pull request

on: [push, pull_request] fired both events for any push to a branch with an open PR. The concurrency group can't collapse them:

group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}

Pull requests key on branch name, everything else on commit SHA — so the two runs land in different groups and neither cancels the other, and the push key is unique per push so it never matches anything at all. The result was two full 20-job matrices per push.

push is now scoped to master, leaving pull requests covered by pull_request alone while still running the suite on merges. Manual re-runs are unaffected.

It demonstrated itself on its own commit:

Commit	Events fired
0b87b39 (matrix change)	push + pull_request
b835d49 (trigger fix)	pull_request only

Testing

Full matrix green before the PHPStan commit was dropped: 23/23 jobs passing — 20 test legs (PHP 8.1–8.5 × 4 WordPress versions), Lint PHP & PHP Compatibility, Lint JS & CSS, Build.

This revision only removes a phpstan.dist.neon hunk; git diff origin/master..HEAD now touches .github/workflows/test.yml and nothing else.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: georgestephanis <georgestephanis@git.wordpress.org>
Co-authored-by: masteradhoc <masteradhoc@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[georgestephanis]

Dropped the PHPStan commit — #972 fixes that error better than this did.

Brian's approach removes includes/ from PHPStan's paths: entirely, which lines up with the */includes/* exclusion already in phpcs.xml.dist:45. My scoped ignoreErrors entry cited that same precedent as a reason to go narrower, which reads backwards now — the precedent supports the directory-level exclusion. #972 also bumps PHPStan 1.12.34 → 2.2.13, removing the stale-version warning rather than working around it.

For the record, I checked whether the two would have conflicted if both landed: git merge-tree auto-merges cleanly, and running the merged config produced [OK] No errors rather than an unmatched-ignore failure. So they'd have coexisted — my entry would just have been dead config pointing at an unanalysed file. Cleaner to drop it.

This PR is now workflow-only: fail-fast: false, the EOL matrix legs, and the duplicate-run trigger. git diff origin/master..HEAD touches .github/workflows/test.yml and nothing else.

[masteradhoc]

LGTM