Skip to content

Fix: Accordion toggles in the Connectors > AI plugin page miss a focus style - #1035

Merged
dkotter merged 3 commits into
WordPress:developfrom
hbhalodia:fix/issue-1034
Sep 22, 2026
Merged

dkotter merged 3 commits into
WordPress:developfrom
hbhalodia:fix/issue-1034

Conversation

@hbhalodia

@hbhalodia hbhalodia commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

What?

Closes #1034

Why?

  • Used to fix the focus styles on the collapsible cards.

How?

  • Updates the @wordpress/dataviews and @wordpress/data to latest npm version.

Use of AI Tools

  • None

Testing Instructions

  • Go to WP Admin > Connectors.
  • Install and activate the AI plugin.
  • You will be redirected to the AI plugin settings page wp-admin/options-general.php?page=ai-wp-admin
  • Use the tab key to navigate the page.
  • Observe that when you land on on one of the accordion toggles (Editor Experiments or Admin Experiments) there is a tab stop and there should be a focus style.

Screenshots or screencast

Before

Screen.Recording.2026-09-16.at.2.31.01.PM.mov

After

Screen.Recording.2026-09-16.at.2.36.37.PM.mov

Changelog Entry

Fixed - Fix focus style on collapsible card by updating the @wordpress/dataviews package to latest version.

Open WordPress Playground Preview

@hbhalodia
hbhalodia requested a review from a team September 16, 2026 09:08
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: dkotter <dkotter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.78%. Comparing base (f0ec176) to head (4497eef).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1035   +/-   ##
==========================================
  Coverage      80.78%   80.78%           
  Complexity      2998     2998           
==========================================
  Files            124      124           
  Lines          11978    11978           
==========================================
  Hits            9677     9677           
  Misses          2301     2301           
Flag Coverage Δ
unit 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dkotter
dkotter previously approved these changes Sep 21, 2026
@dkotter

dkotter commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@hbhalodia I think I'm fine proceeding with this though there's a merge conflict that needs resolved first

@hbhalodia

Copy link
Copy Markdown
Contributor Author

Thanks @dkotter, I have resolved the conflicts. The review got staled. Need approval again to merge.

@dkotter
dkotter merged commit 3f5a773 into WordPress:develop Sep 22, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion toggles in the Connectors > AI plugin page miss a focus style

2 participants