Skip to content

Fix long member values messing up list scrolling in inspector - #100

Merged
ManlyMarco merged 2 commits into
masterfrom
fix-insp
Apr 11, 2025
Merged

ManlyMarco merged 2 commits into
masterfrom
fix-insp

Conversation

@ManlyMarco

Copy link
Copy Markdown
Owner

No description provided.

@ManlyMarco
ManlyMarco requested a review from Copilot April 11, 2025 14:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs:16

  • Renaming the constant and changing its accessibility from private to internal requires verifying that external references are updated accordingly. Please confirm that the broader codebase does not depend on the original private declaration.
internal const int InspectorRecordInitialHeight = 25;

RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs:411

  • Using a hard-coded value (130) for calculating visible scroll area may lead to display inconsistencies on different screen sizes or window configurations. Consider refactoring this logic to calculate the offset dynamically based on runtime measurements.
var scrollMaxVisibleY = scrollPositionY + ((int)WindowRect.height - 130);

@ManlyMarco
ManlyMarco merged commit 567339d into master Apr 11, 2025
@ManlyMarco
ManlyMarco deleted the fix-insp branch April 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants