Android support#161
Merged
Merged
Conversation
NeedleInAJayStack
previously approved these changes
Jan 7, 2025
NeedleInAJayStack
left a comment
Member
There was a problem hiding this comment.
Woah, this is awesome! I didn't know that NIO was adding Android support! These changes look great to me.
Don't worry about the format CI job - it periodically breaks as swiftformat is updated. I've opened an MR that fixes them here so we'll just rebase when that goes through.
Thanks for contributing!
Contributor
Author
|
Now that swift-nio 2.78.0 has been released, I've updated this PR to add an Android CI action that builds and tests on an Android emulator using the swift-android-action, which passes in my test run. |
Member
|
@marcprux I've merged the formatting fixes so if you rebase on main you should be good to go! Thanks! |
NeedleInAJayStack
approved these changes
Jan 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the minimal changes needed for Android support.
It won't build for Android yet until aswift-niorelease is cut that includes apple/swift-nio#3033, but if you switch theswift-niodependency tobranch: "main", test cases will pass (e.g., by runningskip android testor using the swift-android-action github action).It builds and passes all the tests on Android as of swift-nio 2.78.0 .