fix: [test] reset DefaultLogger.initialized in LoggerTest #3732 regressions

[robfrank]

Summary

• LoggerTest.logDirectoryCreatedFromConfiguredFileHandlerPattern and logDirectoryCreatedWithTmpDirSubstitution fail when sibling tests (or TestHelper) have already triggered logging in the JVM.
• Root cause: DefaultLogger.initialized is a static volatile flag. Once set, init() returns at the top and the directory-creation logic (createLogDirectoryFromConfig()) never runs - so the test's expected directory is not created.
• The flag exists for a good reason (prevents re-reading the JUL config and clobbering logger levels when tests swap in a capturing logger), so production semantics must stay as-is.
• Fix: reset the static flag via reflection before each test that depends on init() doing work.

Test plan

• mvn -pl engine test -Dtest=LoggerTest - 4/4 pass

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · -7.10% coverage variation

Metric	Results
Coverage variation	✅ -7.10% coverage variation
Diff coverage	✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (750f2a6)	126737	93324	73.64%
Head commit (03321cc)	158415 (+31678)	105403 (+12079)	66.54% (-7.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4206)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[gemini-code-assist]

Code Review

This pull request introduces a reflection-based utility method, resetDefaultLoggerInitialized, to reset the static initialized flag in DefaultLogger during unit tests. This ensures that the logger's initialization logic is triggered consistently across different test scenarios. The reviewer suggested refactoring these manual reset calls into a @beforeeach method to improve test robustness and reduce code duplication, which would also necessitate adding the appropriate JUnit import.

[gemini-code-assist]

Add the BeforeEach import to support the suggested refactoring of the logger reset logic.

Suggested change

	import java.lang.reflect.Field;
	import org.junit.jupiter.api.BeforeEach;
	import java.lang.reflect.Field;

[gemini-code-assist]

Instead of manually calling resetDefaultLoggerInitialized() in each test method, consider using a @BeforeEach method. This ensures that the global state of the DefaultLogger is reset before every test, making the tests more robust against execution order and reducing code duplication. Once this refactoring is applied, the manual calls at lines 68, 111, and 153 can be removed.

Suggested change

	private static void resetDefaultLoggerInitialized() throws ReflectiveOperationException {
	final Field f = DefaultLogger.class.getDeclaredField("initialized");
	f.setAccessible(true);
	f.setBoolean(null, false);
	}
	@BeforeEach
	void resetDefaultLoggerInitialized() throws ReflectiveOperationException {
	final Field f = DefaultLogger.class.getDeclaredField("initialized");
	f.setAccessible(true);
	f.setBoolean(null, false);
	}

[claude]

test

[claude]

Part 1 of review - deleting test comment posted earlier

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.98%. Comparing base (750f2a6) to head (03321cc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
+ Coverage   64.58%   64.98%   +0.39%     
==========================================
  Files        1643     1643              
  Lines      126737   126737              
  Branches    27127    27127              
==========================================
+ Hits        81855    82358     +503     
+ Misses      33442    32826     -616     
- Partials    11440    11553     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.