move authneg bit - #12949
Closed
icing wants to merge 2 commits into
Closed
Conversation
- from `conn->bits.authneg` to `data->req.authneg` - AFAICT, this is a property of the request about to be made and not a property of the connection - in multiuse connections, transfer could step on each others toes here potentially.
icing
marked this pull request as ready for review
February 16, 2024 11:17
Member
|
hm. I feel like there was probably a good reason authneg was put on the connection level... maybe because of authentications that are connection level and not request level like NTLM and that is why? |
Contributor
Author
|
AFAICT, it was only used to make the special tweaks for an empty PUT/POST when auth negotiation was still ongoing. |
Member
bagder
approved these changes
Feb 19, 2024
bagder
left a comment
Member
There was a problem hiding this comment.
I believe this is a correct change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conn->bits.authnegtodata->req.authneg