Closed Bug 2046602 Opened 3 months ago Closed 1 month ago

Add view-timeline-inset into view-timeline shorthand

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
155 Branch
Tracking Flags:
Tracking Status
firefox155 --- fixed

People

(Reporter: boris, Assigned: dshin)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: dev-doc-complete, Whiteboard: [scrollanimation:mvp])

Attachments

(1 file)

Bug 2046602: Make view-timeline-inset part of the view-timeline shorthand. r=#scroll-animation
48 bytes, text/x-phabricator-request
Details | Review

So it seems the shorthand syntax of view-timeline has been changed but we didn't add view-timeline-inset into its sub-properties.

This has the impact on view-timeline-shorthand.html

Whiteboard: [scrollanimation:triage]
Whiteboard: [scrollanimation:triage] → [scrollanimation:triage][scrollanimation:m2]
Whiteboard: [scrollanimation:triage][scrollanimation:m2] → [scrollanimation:m2]
Keywords: dev-doc-needed
Points: --- → 1
Blocks: 2055345
No longer blocks: 2055345
Blocks: 2055345
Assignee: nobody → dshin
Status: NEW → ASSIGNED
Pushed by dshin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/de088c7a6bd8 https://hg.mozilla.org/integration/autoland/rev/91d9d9d66765 Make view-timeline-inset part of the view-timeline shorthand. r=layout-scroll-driven-animation-reviewers,firefox-style-system-reviewers,emilio,boris
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1dcc9a592e6f https://hg.mozilla.org/integration/autoland/rev/f895691ba757 Revert "Bug 2046602: Make view-timeline-inset part of the view-timeline shorthand. r=layout-scroll-driven-animation-reviewers,firefox-style-system-reviewers,emilio,boris" for causing layout related mochitest failures.
Pushed by dshin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fae2051de655 https://hg.mozilla.org/integration/autoland/rev/dbd1d79481ee Make view-timeline-inset part of the view-timeline shorthand. r=layout-scroll-driven-animation-reviewers,firefox-style-system-reviewers,emilio,boris

https://hg.mozilla.org/mozilla-central/rev/dbd1d79481ee

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox155: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch
Whiteboard: [scrollanimation:m2] → [scrollanimation:mvp]
Duplicate of this bug: 2055345
QA Whiteboard: [qa-triage-done-c156/b155]
Flags: needinfo?(dshin)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: