Re: [for-5.0 3/4] spapr: Fold h_cas_compose_response() into h_client_architecture_support()

2019-12-02 Thread Greg Kurz
On Fri, 29 Nov 2019 16:33:55 +1100 David Gibson wrote: > spapr_h_cas_compose_response() handles the last piece of the PAPR feature > negotiation process invoked via the ibm,client-architecture-support OF > call. Its only caller is h_client_architecture_support() which handles > most of the rest

Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs

2019-12-02 Thread David Hildenbrand
[...] > First search hit. Here's my second one: > > Q: What are latent bugs? > > A: These bugs do not cause problems today. However, they are lurking > just waiting to reveal themselves later. The Ariane 5 rocket > failure was caused by a float->int conversion error that lay do

Re: [for-5.0 1/4] spapr: Don't trigger a CAS reboot for XICS/XIVE mode changeover

2019-12-02 Thread David Gibson
On Mon, Dec 02, 2019 at 08:50:09AM +0100, Greg Kurz wrote: > On Fri, 29 Nov 2019 16:33:53 +1100 > David Gibson wrote: > > > PAPR allows the interrupt controller used on a POWER9 machine (XICS or > > XIVE) to be selected by the guest operating system, by using the > > ibm,client-architecture-suppo

Re: [for-5.0 3/4] spapr: Fold h_cas_compose_response() into h_client_architecture_support()

2019-12-02 Thread David Gibson
On Mon, Dec 02, 2019 at 09:23:35AM +0100, Greg Kurz wrote: > On Fri, 29 Nov 2019 16:33:55 +1100 > David Gibson wrote: > > > spapr_h_cas_compose_response() handles the last piece of the PAPR feature > > negotiation process invoked via the ibm,client-architecture-support OF > > call. Its only call

Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Michael Rolnik wrote: > Aleksandar. > > I could not find what happens if an instruction with unsupported registers > is executed. So, I am leaving this tiny core for later. > > No problem with me. You already have instruction support for a rich variety of cores. These

Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size()

2019-12-02 Thread Greg Kurz
On Fri, 29 Nov 2019 12:35:01 +1100 David Gibson wrote: > This function calculates the maximum size of the RMA as implied by the > host's page size of structure of the VRMA (there are a number of other > constraints on the RMA size which will supersede this one in many > circumstances). > > The c

Re: [PATCH 0/3] s390x: Increase architectural compliance

2019-12-02 Thread Cornelia Huck
On Fri, 29 Nov 2019 09:20:22 -0500 Janosch Frank wrote: > On a diag 308 subcode 0 and 1 we need to load the whole reset PSW and > not just the address. > > On a cpu reset normal, we need to clear local cpus. Unfortunately we > need a new API for that, since KVM only exposes one of the three > re

Re: [PATCH 0/3] s390x: Increase architectural compliance

2019-12-02 Thread Janosch Frank
On 12/2/19 9:57 AM, Cornelia Huck wrote: > On Fri, 29 Nov 2019 09:20:22 -0500 > Janosch Frank wrote: > >> On a diag 308 subcode 0 and 1 we need to load the whole reset PSW and >> not just the address. >> >> On a cpu reset normal, we need to clear local cpus. Unfortunately we >> need a new API for

Re: [PATCH v37 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Aleksandar Markovic < [email protected]> wrote: > > > + > +/* update status register */ > +tcg_gen_movi_tl(cpu_Vf, 0); /* Vf = 0 */ > +tcg_gen_setcondi_tl(TCG_COND_EQ, cpu_Zf, R, 0); /* Zf = R == 0 */ > +gen_ZNSf(R); > +tcg_gen_mov_tl(Rd, R

vfio_pin_map_dma cause synchronize_sched wait too long

2019-12-02 Thread Longpeng (Mike)
Hi guys, Suppose there're two VMs: VM1 is bind to node-0 and calling vfio_pin_map_dma(), VM2 is a migrate incoming VM which bind to node-1. We found the vm_start( QEMU function) of VM2 will take too long occasionally, the reason is as follow. - VM2 - qemu: vm_start vm_start_notify

Re: [PATCH 1/3] s390x: Properly fetch and test the short psw on diag308 subc 0/1

2019-12-02 Thread Cornelia Huck
On Fri, 29 Nov 2019 09:20:23 -0500 Janosch Frank wrote: > We need to actually fetch the cpu mask and set it. As we invert the > short psw indication in the mask, SIE will report a specification > exception, if it wasn't present in the reset psw. > > Signed-off-by: Janosch Frank > Reviewed-by: D

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-12-02 Thread David Hildenbrand
>> Say the user has the option to select a model (zEC12, z13, z14), upper >> layers always want to have a model that includes all backported security >> features. While the host model can do that, CPU definitions can't. You >> can't change default models within a QEMU release, or for older releas

Re: [PATCH v2 01/13] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-12-02 Thread Cornelia Huck
On Fri, 29 Nov 2019 15:08:58 +0100 Janosch Frank wrote: > On 11/29/19 1:40 PM, Thomas Huth wrote: > > On 29/11/2019 10.47, Janosch Frank wrote: > > [...] > >> Subcodes 8-10 are not valid in protected mode, we have to do a subcode > >> 3 and then the 8 and 10 combination for a protected reboot.

Re: vfio_pin_map_dma cause synchronize_sched wait too long

2019-12-02 Thread Paolo Bonzini
On 02/12/19 10:10, Longpeng (Mike) wrote: > > Suppose there're two VMs: VM1 is bind to node-0 and calling > vfio_pin_map_dma(), > VM2 is a migrate incoming VM which bind to node-1. We found the vm_start( QEMU > function) of VM2 will take too long occasionally, the reason is as follow. Which part

Re: [PATCH v6] ppc: well form kvmppc_hint_smt_possible error hint helper

2019-12-02 Thread Vladimir Sementsov-Ogievskiy
02.12.2019 5:39, David Gibson wrote: > On Wed, Nov 27, 2019 at 10:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Make kvmppc_hint_smt_possible hint append helper well formed: >> rename errp to errp_in, as it is IN-parameter here (which is unusual >> for errp), rename function to be kvmppc_er

Re: [PATCH v6] 9pfs: well form error hint helpers

2019-12-02 Thread Vladimir Sementsov-Ogievskiy
28.11.2019 1:37, Greg Kurz wrote: > On Wed, 27 Nov 2019 22:15:49 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> Make error_append_security_model_hint and >> error_append_socket_sockfd_hint hint append helpers well formed: >> rename errp to errp_in, as it is IN-parameter here (which is unusual >

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-12-02 Thread Aleksandar Markovic
On Saturday, November 30, 2019, Michael Rolnik wrote: > There is *-cpu *option where you can specify what CPU you want, if this > option is not specified avr6 (avr6-avr-cpu) is chosen. > > *./avr-softmmu/qemu-system-avr -cpu help* > avr1-avr-cpu > avr2-avr-cpu > avr25-avr-cpu > avr3-avr-cpu > avr

Re: virtiofsd: Where should it live?

2019-12-02 Thread Michael S. Tsirkin
On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > >

Re: vfio_pin_map_dma cause synchronize_sched wait too long

2019-12-02 Thread Longpeng (Mike)
在 2019/12/2 17:31, Paolo Bonzini 写道: > On 02/12/19 10:10, Longpeng (Mike) wrote: >> >> Suppose there're two VMs: VM1 is bind to node-0 and calling >> vfio_pin_map_dma(), >> VM2 is a migrate incoming VM which bind to node-1. We found the vm_start( >> QEMU >> function) of VM2 will take too long occ

Re: [PATCH 02/21] net/virtio: Fix failover error handling crash bugs

2019-12-02 Thread Jens Freimann
On Sat, Nov 30, 2019 at 08:42:21PM +0100, Markus Armbruster wrote: Functions that take an Error ** parameter to pass an error to the caller expect the parameter to point to null. failover_replug_primary() violates this precondition in several places: * After qemu_opts_from_qdict() failed, *errp

Re: [PATCH v10 1/3] block: introduce compress filter driver

2019-12-02 Thread Andrey Shinkevich
On 28/11/2019 17:37, Vladimir Sementsov-Ogievskiy wrote: > 28.11.2019 12:36, Andrey Shinkevich wrote: >> Allow writing all the data compressed through the filter driver. >> The written data will be aligned by the cluster size. >> Based on the QEMU current implementation, that data can be written

Re: [PATCH 01/21] net/virtio: Drop useless n->primary_dev not null checks

2019-12-02 Thread Jens Freimann
On Sat, Nov 30, 2019 at 08:42:20PM +0100, Markus Armbruster wrote: virtio_net_handle_migration_primary() returns early when it can't ensure n->primary_dev is non-null. Checking it again right after that early return is redundant. Drop. If n->primary_dev is null on entering failover_replug_prim

Re: [PATCH 18/21] s390x: Fix latent query-cpu-definitions error handling bug

2019-12-02 Thread David Hildenbrand
On 30.11.19 20:42, Markus Armbruster wrote: > qmp_query_cpu_definitions() tries to ignore get_max_cpu_model()'s > errors. However, it crashes when its @errp argument is null or > &error_abort, and exit(1)s when it's &error_fatal. Messed up in > commit 38cba1f4d8 "s390x: return unavailable feature

Re: [PATCH 14/21] s390x/event-facility: Fix latent realize() error handling bug

2019-12-02 Thread David Hildenbrand
On 30.11.19 20:42, Markus Armbruster wrote: > sclp_events_bus_realize() crashes when object_property_set_bool() > fails and its @errp argument is null. Messed up in commit f6102c329c > "s390/sclp: rework sclp event facility initialization + device > realization". > s/crashes .../would crash .../

Re: Network connection with COLO VM

2019-12-02 Thread Dr. David Alan Gilbert
* Daniel Cho ([email protected]) wrote: > Hi Zhang, > > We use qemu-4.1.0 release on this case. > > I think we need use block mirror to sync the disk to secondary node first, > then stop the primary VM and build COLO system. > > In the stop moment, you need add some netfilter and chardev socket

Re: [PATCH 15/21] s390x/cpu_models: Fix latent feature property error handling bugs

2019-12-02 Thread David Hildenbrand
On 30.11.19 20:42, Markus Armbruster wrote: > s390x-cpu property setters set_feature() and set_feature_group() crash > when the visitor fails and its @errp argument is null. Messed up in > commit 0754f60429 "s390x/cpumodel: expose features and feature groups > as properties". Same comment as to t

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Aleksandar Markovic < [email protected]> wrote: > > > On Saturday, November 30, 2019, Michael Rolnik wrote: > >> There is *-cpu *option where you can specify what CPU you want, if this >> option is not specified avr6 (avr6-avr-cpu) is chosen. >> >> *./avr-so

Re: [PATCH 03/21] block/file-posix: Fix laio_init() error handling crash bug

2019-12-02 Thread Stefan Hajnoczi
On Sat, Nov 30, 2019 at 08:42:22PM +0100, Markus Armbruster wrote: > raw_aio_attach_aio_context() passes uninitialized Error *local_err by > reference to laio_init() via aio_setup_linux_aio(). When laio_init() > fails, it passes it on to error_setg_errno(), tripping error_setv()'s > assertion unle

Re: vfio_pin_map_dma cause synchronize_sched wait too long

2019-12-02 Thread Paolo Bonzini
On 02/12/19 10:42, Longpeng (Mike) wrote: >> cond_resched in vfio_iommu_map. Perhaps you could add one to >> vfio_pin_pages_remote and/or use vfio_pgsize_bitmap to cap the >> number of pages that it returns. > Um ... There's only one running task (qemu-kvm of the VM1) on that > CPU, so maybe the

Re: libcap vs libcap-ng mess

2019-12-02 Thread Dr. David Alan Gilbert
* Paolo Bonzini ([email protected]) wrote: > Il ven 29 nov 2019, 19:54 Dr. David Alan Gilbert ha > scritto: > > > > Yes, it's per thread. The state can be built from > > > capng_clear/capng_get_caps_process + capng_update, and left in there > > > forever. There is also capng_save_state/capng_

[PATCH v4 0/6] Enable more iotests during "make check-block"

2019-12-02 Thread Thomas Huth
As discussed here: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html and here: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html it would be good to have some more valuable iotests enabled in the "auto" group to get better iotest coverage during "make check

[PATCH v4 1/6] iotests: remove 'linux' from default supported platforms

2019-12-02 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that alwa

[PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-12-02 Thread Thomas Huth
In the long term, we might want to add test 183 to the "auto" group (but it still fails occasionally, so we cannot do that yet). However, when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it currently always fails with an "Timeout waiting for return on handle 0" error. L

[PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-12-02 Thread Thomas Huth
According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for ioth

[PATCH v4 2/6] iotests: Test 041 only works on certain systems

2019-12-02 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-i

[PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2019-12-02 Thread Thomas Huth
We are going to enable some of the python-based tests in the "auto" group, and these tests require virtio-blk to work properly. Running iotests without virtio-blk likely does not make too much sense anyway, so instead of adding a check for the availability of virtio-blk to each and every test (whic

[PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127

2019-12-02 Thread Thomas Huth
We are going to enable 127 in the "auto" group, but it only works if virtio-scsi and scsi-hd are available - which is not the case with QEMU binaries like qemu-system-tricore for example, so we need a proper check for the availability of these devices here. A very similar problem exists in iotest

Re: virtiofsd: Where should it live?

2019-12-02 Thread Peter Maydell
On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé ([email protected]) wrote: > > My main objection to 'contrib/' is actually the perceived notions > > about what the contrib directory is for. When I see 'contrib/' > > code in either QEMU, or other open source p

Re: [PATCH v37 10/17] target/avr: Add instruction disassembly function

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Michael Rolnik wrote: > Aleksandar. > > If this code is going to be merge in 2019 I should modify al the > copyrights, right. or should I put 2020 in? > > I don't have a better answer other than: :)) > Regards, > Michael Rolnik > > On Mon, Dec 2, 2019 at 2:28

[PATCH 3/3] iotests: Skip test 079 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
Test 079 fails in the arm64, s390x and ppc64le LXD containers on Travis (which we will hopefully enable in our CI soon). These containers apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, which is apparently already too big for these containers, so check

Re: [PATCH 00/21] Error handling fixes, may contain 4.2 material

2019-12-02 Thread Daniel P . Berrangé
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: > PATCH 2-4 fix crash bugs. Including them would be a no-brainer at > -rc0. But we're post -rc3, and even for crash bugs we require a > certain likelihood of users getting bitten. > > Jens, please assess impact of PATCH 2's crash

[PATCH 0/3] iotests: Check for the possibility to create large files

2019-12-02 Thread Thomas Huth
Travis recently added the possibility to test on ppc64le, arm64 and s390x hosts, too. However, the containers are very restricted there and do not allow the creation of large files, so that the tests 060 and 079 are currently failing there. So let's add some proper checks to these tests first. Tho

[PATCH 2/3] iotests: Skip test 060 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
Test 060 fails in the arm64, s390x and ppc64le LXD containers on Travis (which we will hopefully enable in our CI soon). These containers apparently do not allow large files to be created. The repair process in test 060 creates a file of 64 GiB, so test first whether such large files are possible a

[PATCH 1/3] iotests: Provide a function for checking the creation of huge files

2019-12-02 Thread Thomas Huth
Some tests create huge (but sparse) files, and to be able to run those tests in certain limited environments (like CI containers), we have to check for the possibility to create such files first. Thus let's introduce a common function to check for large files, and replace the already existing check

Re: [PATCH v4 01/37] qdev: remove unused qdev_prop_int64

2019-12-02 Thread Marc-André Lureau
Hi On Mon, Dec 2, 2019 at 9:23 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Signed-off-by: Marc-André Lureau > > --- > > hw/core/qdev-properties.c| 32 > > include/hw/qdev-properties.h | 3 --- > > 2 files changed, 35 deletions(-) > > >

Re: libcap vs libcap-ng mess

2019-12-02 Thread Paolo Bonzini
On 02/12/19 11:07, Dr. David Alan Gilbert wrote: > * Paolo Bonzini ([email protected]) wrote: >> Il ven 29 nov 2019, 19:54 Dr. David Alan Gilbert ha >> scritto: >> Yes, it's per thread. The state can be built from capng_clear/capng_get_caps_process + capng_update, and left in there >>

Re: [PATCH] ci: Use libcap-ng

2019-12-02 Thread Greg Kurz
On Fri, 29 Nov 2019 16:51:29 +0100 Philippe Mathieu-Daudé wrote: > On 11/29/19 3:21 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > We currently enable libcap-dev in build-clang to pick up the 9p proxy > > helper. Paolo's patch changes that to use libcap-ng,

Re: [PATCH] ci: Use libcap-ng

2019-12-02 Thread Thomas Huth
On 02/12/2019 11.41, Greg Kurz wrote: > On Fri, 29 Nov 2019 16:51:29 +0100 > Philippe Mathieu-Daudé wrote: > >> On 11/29/19 3:21 PM, Dr. David Alan Gilbert (git) wrote: >>> From: "Dr. David Alan Gilbert" >>> >>> We currently enable libcap-dev in build-clang to pick up the 9p proxy >>> helper. P

Re: vfio_pin_map_dma cause synchronize_sched wait too long

2019-12-02 Thread Longpeng (Mike)
在 2019/12/2 18:06, Paolo Bonzini 写道: > On 02/12/19 10:42, Longpeng (Mike) wrote: >>> cond_resched in vfio_iommu_map. Perhaps you could add one to >>> vfio_pin_pages_remote and/or use vfio_pgsize_bitmap to cap the >>> number of pages that it returns. >> Um ... There's only one running task (qemu-k

Re: [PATCH] docker: remove libcap development packages

2019-12-02 Thread Greg Kurz
On Fri, 29 Nov 2019 16:08:01 +0100 Paolo Bonzini wrote: > Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well. > > Signed-off-by: Paolo Bonzini > --- Similarly to what was discussed in these threads: [email protected] 20191129142126.32967-1-d

[PATCH v11 2/3] qcow2: Allow writing compressed data of multiple clusters

2019-12-02 Thread Andrey Shinkevich
QEMU currently supports writing compressed data of the size equal to one cluster. This patch allows writing QCOW2 compressed data that exceed one cluster. Now, we split buffered data into separate clusters and write them compressed using the block/aio_task API. Suggested-by: Pavel Butsykin Sugges

[PATCH v11 0/3] qcow2: advanced compression options

2019-12-02 Thread Andrey Shinkevich
The compression filter driver is introduced as suggested by Max. A sample usage of the filter can be found in the test #214. Now, multiple clusters can be written compressed. It is useful for the backup job. v11: 01: The device name was replaced with the filter underlying format name in th

[PATCH v11 1/3] block: introduce compress filter driver

2019-12-02 Thread Andrey Shinkevich
Allow writing all the data compressed through the filter driver. The written data will be aligned by the cluster size. Based on the QEMU current implementation, that data can be written to unallocated clusters only. May be used for a backup job. Suggested-by: Max Reitz Signed-off-by: Andrey Shink

[PATCH v11 3/3] tests/qemu-iotests: add case to write compressed data of multiple clusters

2019-12-02 Thread Andrey Shinkevich
Add the case to the iotest #214 that checks possibility of writing compressed data of more than one cluster size. The test case involves the compress filter driver showing a sample usage of that. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz -

Re: [PATCH v5 03/13] hw/core: create Resettable QOM interface

2019-12-02 Thread Damien Hedde
On 11/29/19 7:32 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> This commit defines an interface allowing multi-phase reset. This aims >> to solve a problem of the actual single-phase reset (built in >> DeviceClass and BusClass): reset behavior is dependent on

[Bug 1848556] Update Released

2019-12-02 Thread Łukasz Zemczak
The verification of the Stable Release Update for qemu has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

2019-12-02 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.0+dfsg-0ubuntu9.2 --- qemu (1:4.0+dfsg-0ubuntu9.2) eoan; urgency=medium * d/p/ubuntu/lp-1848556-curl-Handle-success-in-multi_check_completion.patch: fix a potential hang when qemu or qemu-img where accessing http backed disks via

Re: [PATCH v5 03/13] hw/core: create Resettable QOM interface

2019-12-02 Thread Peter Maydell
On Mon, 2 Dec 2019 at 11:07, Damien Hedde wrote: > > > On 11/29/19 7:32 PM, Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 16:07, Damien Hedde > > wrote: > >> +/** > >> + * enter_phase_in_progress: > >> + * Flag telling whether we are currently in an enter phase where side > >> + * effects are

[PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-02 Thread pannengyuan
From: PanNengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in g_malloc0

Re: [PATCH v4 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR

2019-12-02 Thread Marc-André Lureau
Hi On Sun, Dec 1, 2019 at 10:10 PM Peter Maydell wrote: > > On Sun, 1 Dec 2019 at 17:27, Marc-André Lureau > wrote: > > > > Hi > > > > On Sun, Dec 1, 2019 at 9:18 PM Peter Maydell > > wrote: > > > > > > On Sun, 1 Dec 2019 at 10:19, Marc-André Lureau > > > wrote: > > > > > > > > - "serial: reg

iPXE: update submodule

2019-12-02 Thread Philippe Mathieu-Daudé
Hi Gerd, 'make -C roms efirom' is failing on Fedora 30. Can you update the iPXE submodule so we get these buildsys commits: c742c576 [build] Move predefined all-drivers build shortcut to Makefile a4f8c6e3 [build] Do not apply WORKAROUND_CFLAGS for host compiler 1dd56dbd [build] Workaround compi

Re: [PATCH v11 1/3] block: introduce compress filter driver

2019-12-02 Thread Vladimir Sementsov-Ogievskiy
02.12.2019 13:57, Andrey Shinkevich wrote: > Allow writing all the data compressed through the filter driver. > The written data will be aligned by the cluster size. > Based on the QEMU current implementation, that data can be written to > unallocated clusters only. May be used for a backup job. >

Re: [PATCH 00/21] Error handling fixes, may contain 4.2 material

2019-12-02 Thread Jens Freimann
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: PATCH 2-4 fix crash bugs. Including them would be a no-brainer at -rc0. But we're post -rc3, and even for crash bugs we require a certain likelihood of users getting bitten. Jens, please assess impact of PATCH 2's crash bug.

Re: [PATCH v5 04/13] hw/core: add Resettable support to BusClass and DeviceClass

2019-12-02 Thread Damien Hedde
On 11/29/19 7:36 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> This commit adds support of Resettable interface to buses and devices: >> + ResettableState structure is added in the Bus/Device state >> + Resettable methods are implemented. >> + device/bus_is_

Re: [PATCH 2/7] ppm-save: pass opened fd

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:51:57PM +0400, Marc-André Lureau wrote: > This will allow to pre-open the file before running the async finish > handler and avoid potential monitor fdset races. > > (note: this is preliminary work for asynchronous screendump support) > > Signed-off-by: Marc-André Lurea

Re: [PATCH 3/7] ui: add pixman image g_autoptr support

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:51:58PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/ui/qemu-pixman.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos

Re: [PATCH 4/7] object: add g_autoptr support

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:51:59PM +0400, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/qom/object.h | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/db

Re: [PATCH 5/7] screendump: replace FILE with QIOChannel and fix close()/qemu_close()

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:52:00PM +0400, Marc-André Lureau wrote: > The file opened for ppm_save() may be a /dev/fdset, in which case a > dup fd is added to the fdset. It should be removed by calling > qemu_close(), instead of the implicit close() on fclose(). > > I don't see a convenient way to

Re: [PATCH v5 05/13] hw/core/resettable: add support for changing parent

2019-12-02 Thread Damien Hedde
On 11/29/19 7:38 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> Add a function resettable_change_parent() to do the required >> plumbing when changing the parent a of Resettable object. >> >> We need to make sure that the reset state of the object remains >>

Re: [PATCH 7/7] screendump: use qemu_unlink()

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:52:02PM +0400, Marc-André Lureau wrote: > Don't attempt to remove /dev/fdset files. > > Signed-off-by: Marc-André Lureau > --- > ui/console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berr

Re: [PATCH 6/7] osdep: add qemu_unlink()

2019-12-02 Thread Daniel P . Berrangé
On Wed, Nov 27, 2019 at 03:52:01PM +0400, Marc-André Lureau wrote: > Add a helper function to match qemu_open() which may return files > under the /dev/fdset prefix. Those shouldn't be removed, since it's > only a qemu namespace. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/osdep.h

Re: [PATCH v37 10/17] target/avr: Add instruction disassembly function

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Michael Rolnik wrote: > Aleksandar. > > If this code is going to be merge in 2019 I should modify al the > copyrights, right. or should I put 2020 in? > > Michael, Initially I saw your message as wry sense of humor. But, in fact, it is not a bad idea at all. Since w

Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops

2019-12-02 Thread Vladimir Sementsov-Ogievskiy
11.11.2019 19:02, Max Reitz wrote: > While bdrv_replace_node() will not follow through with it, a specific > @replaces asks the mirror job to create a loop. > > For example, say both the source and the target share a child where the > source is a filter; by letting @replaces point to the common ch

[PATCH v12 3/3] tests/qemu-iotests: add case to write compressed data of multiple clusters

2019-12-02 Thread Andrey Shinkevich
Add the case to the iotest #214 that checks possibility of writing compressed data of more than one cluster size. The test case involves the compress filter driver showing a sample usage of that. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz -

[PATCH v12 0/3] qcow2: advanced compression options

2019-12-02 Thread Andrey Shinkevich
The compression filter driver is introduced as suggested by Max. A sample usage of the filter can be found in the test #214. Now, multiple clusters can be written compressed. It is useful for the backup job. v12: 01: Missed to change the driver interface .bdrv_co_block_status from _status_

[PATCH v12 1/3] block: introduce compress filter driver

2019-12-02 Thread Andrey Shinkevich
Allow writing all the data compressed through the filter driver. The written data will be aligned by the cluster size. Based on the QEMU current implementation, that data can be written to unallocated clusters only. May be used for a backup job. Suggested-by: Max Reitz Signed-off-by: Andrey Shink

[PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2019-12-02 Thread Andrey Shinkevich
QEMU currently supports writing compressed data of the size equal to one cluster. This patch allows writing QCOW2 compressed data that exceed one cluster. Now, we split buffered data into separate clusters and write them compressed using the block/aio_task API. Suggested-by: Pavel Butsykin Sugges

Re: iPXE: update submodule

2019-12-02 Thread Gerd Hoffmann
On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > 'make -C roms efirom' is failing on Fedora 30. > > Can you update the iPXE submodule so we get these buildsys commits: > > c742c576 [build] Move predefined all-drivers build shortcut to Makefile > a4f8c6e3 [bu

Re: [PATCH 03/21] block/file-posix: Fix laio_init() error handling crash bug

2019-12-02 Thread Kevin Wolf
Am 30.11.2019 um 20:42 hat Markus Armbruster geschrieben: > raw_aio_attach_aio_context() passes uninitialized Error *local_err by > reference to laio_init() via aio_setup_linux_aio(). When laio_init() > fails, it passes it on to error_setg_errno(), tripping error_setv()'s > assertion unless @local

Re: iPXE: update submodule

2019-12-02 Thread Thomas Huth
On 02/12/2019 13.18, Gerd Hoffmann wrote: > On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote: >> Hi Gerd, >> >> 'make -C roms efirom' is failing on Fedora 30. >> >> Can you update the iPXE submodule so we get these buildsys commits: >> >> c742c576 [build] Move predefined all-d

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Damien Hedde
On 11/29/19 8:05 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> Split gpfsel_set() in 2 so that the sdbus reparenting is done >> in a dedicated function. >> >> Signed-off-by: Damien Hedde >> --- >> Cc: Peter Maydell >> Cc: Andrew Baumann >> Cc: Philippe Ma

Re: iPXE: update submodule

2019-12-02 Thread Philippe Mathieu-Daudé
On 12/2/19 1:18 PM, Gerd Hoffmann wrote: On Mon, Dec 02, 2019 at 12:19:50PM +0100, Philippe Mathieu-Daudé wrote: Hi Gerd, 'make -C roms efirom' is failing on Fedora 30. Can you update the iPXE submodule so we get these buildsys commits: c742c576 [build] Move predefined all-drivers build short

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Peter Maydell
On Mon, 2 Dec 2019 at 12:27, Damien Hedde wrote: > > > > On 11/29/19 8:05 PM, Peter Maydell wrote: > > On Fri, 18 Oct 2019 at 16:07, Damien Hedde > > wrote: > >> @@ -97,6 +101,7 @@ static void gpfsel_set(BCM2835GpioState *s, uint8_t > >> reg, uint32_t value) > >> && (s->fsel[53] ==

[PATCH 0/2] Remove 'remote wakeup' flag from USB config descriptor

2019-12-02 Thread Yuri Benditovich
This series of patches addresses possible functional problem of USB devices with 'remote wakeup' capability, redirected to Windows VM (local redirection using libusb or spice redirection using usbredir). Yuri Benditovich (2): usb-host: remove 'remote wakeup' flag from configuration descriptor

[PATCH 2/2] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2019-12-02 Thread Yuri Benditovich
If the redirected device has this capability, Windows guest may place the device into D2 and expect it to wake when the device becomes active, but this will never happen. For example, when internal Bluetooth adapter is redirected, keyboards and mice connected to it do not work. Current commit remov

[PATCH 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2019-12-02 Thread Yuri Benditovich
If the redirected device has this capability, Windows guest may place the device into D2 and expect it to wake when the device becomes active, but this will never happen. For example, when internal Bluetooth adapter is redirected, keyboards and mice connected to it do not work. Current commit remov

Re: virtiofsd: Where should it live?

2019-12-02 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert > wrote: >> >> * Daniel P. Berrangé ([email protected]) wrote: >> > My main objection to 'contrib/' is actually the perceived notions >> > about what the contrib directory is for. When I see 'contrib/' >> > code in ei

Re: [PATCH v11 00/15] Introduce the microvm machine type

2019-12-02 Thread Sergio Lopez
Markus Armbruster writes: > Sergio Lopez writes: > >> microvm is a machine type inspired by Firecracker and constructed >> after its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-lived guests. microvm also establishes a baseline for >> b

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Damien Hedde
On 12/2/19 1:33 PM, Peter Maydell wrote: > On Mon, 2 Dec 2019 at 12:27, Damien Hedde wrote: >> >> >> >> On 11/29/19 8:05 PM, Peter Maydell wrote: >>> On Fri, 18 Oct 2019 at 16:07, Damien Hedde >>> wrote: @@ -97,6 +101,7 @@ static void gpfsel_set(BCM2835GpioState *s, uint8_t reg, ui

Re: [PATCH] docker: remove libcap development packages

2019-12-02 Thread Greg Kurz
On Mon, 2 Dec 2019 11:49:58 +0100 Greg Kurz wrote: > On Fri, 29 Nov 2019 16:08:01 +0100 > Paolo Bonzini wrote: > > > Libcap was dropped from virtio-9p, so remove it from the dockerfiles as > > well. > > > > Signed-off-by: Paolo Bonzini > > --- > > Similarly to what was discussed in these th

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-12-02 Thread Peter Maydell
On Mon, 2 Dec 2019 at 13:05, Damien Hedde wrote: > > I don't know why it has been implemented like this but right now the > raspi_init() does the following during machine creation: > | bus = qdev_get_child_bus(DEVICE(&s->soc), "sd-bus"); > | [...] > | carddev = qdev_create(bus, TYPE_SD_CARD); > wh

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-12-02 Thread Michael Rolnik
No, I don't. but I also can load and execute a binary file which does not have this information. On Mon, Dec 2, 2019 at 11:59 AM Aleksandar Markovic < [email protected]> wrote: > > > On Monday, December 2, 2019, Aleksandar Markovic < > [email protected]> wrote: > >> >> >> On S

Re: virtiofsd: Where should it live?

2019-12-02 Thread Thomas Huth
On 02/12/2019 13.56, Markus Armbruster wrote: > Peter Maydell writes: > >> On Tue, 26 Nov 2019 at 12:15, Dr. David Alan Gilbert >> wrote: >>> >>> * Daniel P. Berrangé ([email protected]) wrote: My main objection to 'contrib/' is actually the perceived notions about what the contrib d

Re: [PATCH v2 06/14] target/arm: use gdb_get_reg helpers

2019-12-02 Thread Alan Hayward
> On 1 Dec 2019, at 20:05, Philippe Mathieu-Daudé wrote: > > On 11/30/19 9:45 AM, Alex Bennée wrote: >> This is cleaner than poking memory directly and will make later >> clean-ups easier. >> Signed-off-by: Alex Bennée >> --- >> v2 >> - make sure we pass hi/lo correctly as quads are stored i

Re: [PATCH v6 1/9] hw/core/clock: introduce clock objects

2019-12-02 Thread Peter Maydell
On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: > > Introduce clock objects: ClockIn and ClockOut. > > These objects may be used to distribute clocks from an object to several > other objects. Each ClockIn object contains the current state of the > clock: the frequency; it allows an object to mig

Re: [PATCH v6 2/9] hw/core/clock-vmstate: define a vmstate entry for clock state

2019-12-02 Thread Peter Maydell
On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: > > Signed-off-by: Damien Hedde > --- > This was in the previous reviewed commit. But it can't be in the > clock.c file in order to allow linux-user builds. Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 1/5] target/arm: Honor HCR_EL2.TID2 trapping requirements

2019-12-02 Thread Edgar E. Iglesias
On Sun, Dec 01, 2019 at 12:20:14PM +, Marc Zyngier wrote: > HCR_EL2.TID2 mandates that access from EL1 to CTR_EL0, CCSIDR_EL1, > CCSIDR2_EL1, CLIDR_EL1, CSSELR_EL1 are trapped to EL2, and QEMU > completely ignores it, making it impossible for hypervisors to > virtualize the cache hierarchy. >

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-02 Thread Laurent Vivier
On 02/12/2019 12:15, [email protected] wrote: > From: PanNengyuan > > ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in > virtio_serial_device_unrealize, the memory leak stack is as bellow: > > Direct leak of 1290240 byte(s) in 180 object(s) allocated from: > #0 0x7fc9bfc27560 in calloc (/u

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-12-02 Thread Aleksandar Markovic
On Monday, December 2, 2019, Michael Rolnik wrote: > No, I don't. > but I also can load and execute a binary file which does not have this > information. > >> >> OK. Let's think about that for a while. I currently think you have here an opportunity to add a really clean interface from the outset

[PATCH v2 2/3] s390x: Add missing vcpu reset functions

2019-12-02 Thread Janosch Frank
Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach for the initial reset, which was also called for the clear reset. To be architecture compliant, we also need to clear local interrupts on a normal reset. Because of this and the upcoming protvirt support we need to add ioctls fo

  1   2   3   4   >