On Mon, 25 Jul 2022, at 16:02, Cédric Le Goater wrote:
> On 7/25/22 04:08, Andrew Jeffery wrote:
>>
>>
>> On Fri, 22 Jul 2022, at 16:06, Cédric Le Goater wrote:
>>> aspeed_machine_witherspoon_class_init(ObjectClass *oc, void *data)
>>> mc->desc = "OpenPOWER Witherspoon BMC (ARM1176)";
>>> amc->soc_name = "ast2500-a1";
>>> amc->hw_strap1 = WITHERSPOON_BMC_HW_STRAP1;
>>> - amc->fmc_model = "mx25l25635e";
>>> + amc->fmc_model = "mx25l25635f";
>>
>> The witherspoon I checked also reported mx25l25635e in dmesg for the
>> FMC.
>>
>> You do say "generally" in the commit message though.
>
> You can not tell from dmesg.
>
> The MX25L25635F and MX25L25635E models share the same JEDEC ID and
> the spi-nor flash device table only contains a mx25l25635e entry.
> The MX25L25635F is detected in mx25l25635_post_bfpt_fixups using SFDP.
>
> That's why I added this warning :
>
>
> https://github.com/legoater/linux/commit/934f0708ac597022cbf6c8d6f2ce91d55025e943
>
Oh righto, sorry for the noise.
