On 18/8/26 03:43, Andrew Jeffery wrote:
Currently, booting Linux on the ast2600-evb machine via -kernel results
in a lot of warnings about failing to apply pinmux configuration when
binding drivers:

     [    7.339307][    T1] Creating 5 MTD partitions on "bmc":
     [    7.340402][    T1] 0x000000000000-0x0000000e0000 : "u-boot"
     [    7.513755][    T1] 0x0000000e0000-0x000000100000 : "u-boot-env"
     [    7.664219][    T1] 0x000000100000-0x000000a00000 : "kernel"
     [    7.826974][    T1] 0x000000a00000-0x000002a00000 : "rofs"
     [    8.026666][    T1] 0x000002a00000-0x000004000000 : "rwfs"
     [    8.201612][    T1] spi-aspeed-smc 1e630000.spi: error -EPERM: Error 
applying setting, reverse things back
     [    8.370835][    T1] spi-aspeed-smc 1e630000.spi: Calibration area too 
uniform, using low speed
     [    8.371131][    T1] spi-aspeed-smc 1e630000.spi: Force to dts 
configuration 100000kHz.
     [    8.371500][    T1] spi-aspeed-smc 1e630000.spi: CE0 read buswidth:4 
[0x406c0741]
     [    8.766797][    T1] mdio-aspeed 1e650000.mdio: error -EPERM: Error 
applying setting, reverse things back
     [    8.906008][    T1] mdio-aspeed 1e650008.mdio: error -EPERM: Error 
applying setting, reverse things back
     [    9.039240][    T1] mdio-aspeed 1e650010.mdio: error -EPERM: Error 
applying setting, reverse things back
     [    9.147942][    T1] mdio-aspeed 1e650018.mdio: error -EPERM: Error 
applying setting, reverse things back

The pinmux configuration fails because the SCU is not unlocked.

Set both SCU protection keys for the AST2600. Further, set them
such that they behave accordance with the read value documented
by the datasheet. The new arrangement now upholds the comment in
hw/arm/aspeed.c regarding passing -kernel on the qemu command-line.

     [    7.568170][    T1] Creating 5 MTD partitions on "bmc":
     [    7.569330][    T1] 0x000000000000-0x0000000e0000 : "u-boot"
     [    7.740372][    T1] 0x0000000e0000-0x000000100000 : "u-boot-env"
     [    7.883570][    T1] 0x000000100000-0x000000a00000 : "kernel"
     [    8.041004][    T1] 0x000000a00000-0x000002a00000 : "rofs"
     [    8.196824][    T1] 0x000002a00000-0x000004000000 : "rwfs"
     [    8.547037][    T1] spi-aspeed-smc 1e630000.spi: Calibration area too 
uniform, using low speed
     [    8.547320][    T1] spi-aspeed-smc 1e630000.spi: Force to dts 
configuration 100000kHz.
     [    8.547642][    T1] spi-aspeed-smc 1e630000.spi: CE0 read buswidth:4 
[0x406c0741]
     [    9.494235][    T1] ftgmac100 1e660000.ethernet: Read MAC address 
52:54:00:12:34:56 from chip
     [    9.531186][    T1] RTL8211E Gigabit Ethernet 1e650000.mdio-1:00: 
attached PHY driver (mii_bus:phy_addr=1e650000.mdio-1:00,

Fixes: e09cf36321f6 ("hw: aspeed_scu: Add AST2600 support")
Signed-off-by: Andrew Jeffery <[email protected]>
---
I ran into this issue while improving test coverage in my patch review
process.
---
  hw/misc/aspeed_scu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Cc: [email protected]
Fixes: e09cf36321f ("hw: aspeed_scu: Add AST2600 support")
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

Reply via email to