arm_load_kernel() keeps a pointer to the boot info struct for the
lifetime of the VM, so the struct logically belongs to the machine
rather than to a function scoped static object.
Move it into a new Mcimx7dSabreMachineState and register the machine
type explicitly instead of through the DEFINE_MACHINE_ARM macro.
As in the xlnx-zcu102 and raspi machines, the boot info belongs to
the machine rather than to a static object:
4d1ac883a7 ("hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102")
0f15c6e338 ("hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState")
Signed-off-by: Bin Meng <[email protected]>
---
hw/arm/mcimx7d-sabre.c | 28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/hw/arm/mcimx7d-sabre.c b/hw/arm/mcimx7d-sabre.c
index a0ac647c3d..22fe1fa932 100644
--- a/hw/arm/mcimx7d-sabre.c
+++ b/hw/arm/mcimx7d-sabre.c
@@ -22,9 +22,19 @@
#include "qemu/error-report.h"
#include "system/qtest.h"
+#define TYPE_MCIMX7D_SABRE_MACHINE MACHINE_TYPE_NAME("mcimx7d-sabre")
+OBJECT_DECLARE_SIMPLE_TYPE(Mcimx7dSabreMachineState,
+ MCIMX7D_SABRE_MACHINE)
+
+struct Mcimx7dSabreMachineState {
+ MachineState parent;
+
+ struct arm_boot_info bootinfo;
+};
+
static void mcimx7d_sabre_init(MachineState *machine)
{
- static struct arm_boot_info boot_info;
+ Mcimx7dSabreMachineState *msms = MCIMX7D_SABRE_MACHINE(machine);
FslIMX7State *s;
int i;
@@ -34,12 +44,10 @@ static void mcimx7d_sabre_init(MachineState *machine)
exit(1);
}
- boot_info = (struct arm_boot_info) {
- .loader_start = FSL_IMX7_MMDC_ADDR,
- .board_id = -1,
- .ram_size = machine->ram_size,
- .psci_conduit = QEMU_PSCI_CONDUIT_SMC,
- };
+ msms->bootinfo.loader_start = FSL_IMX7_MMDC_ADDR;
+ msms->bootinfo.board_id = -1;
+ msms->bootinfo.ram_size = machine->ram_size;
+ msms->bootinfo.psci_conduit = QEMU_PSCI_CONDUIT_SMC;
s = FSL_IMX7(object_new(TYPE_FSL_IMX7));
object_property_add_child(OBJECT(machine), "soc", OBJECT(s));
@@ -65,7 +73,7 @@ static void mcimx7d_sabre_init(MachineState *machine)
}
if (!qtest_enabled()) {
- arm_load_kernel(&s->cpu[0], machine, &boot_info);
+ arm_load_kernel(&s->cpu[0], machine, &msms->bootinfo);
}
}
@@ -78,4 +86,6 @@ static void mcimx7d_sabre_machine_init(MachineClass *mc)
mc->auto_create_sdcard = true;
}
-DEFINE_MACHINE_ARM("mcimx7d-sabre", mcimx7d_sabre_machine_init)
+DEFINE_MACHINE_EXTENDED("mcimx7d-sabre", MACHINE, Mcimx7dSabreMachineState,
+ mcimx7d_sabre_machine_init, false,
+ arm_machine_interfaces)
--
2.53.0