The point of this patch is to allow makensis and the plugins use the same header for common structures.
It also treats exdll.* as more of a example plugin, and all defines except the legacy exdll helper functions are moved to the new header.
Almost all plugins still include exdll.h, except nsDialogs and Math, they use the new PluginUtil.h directly because:
*nsDialogs: has special handling in its popstring (can pop less than g_stringsize when it wants)
*Math: has Math_INIT instead of EXDLL_INIT, etc.
The only plugin that does not use PluginUtil.h in any way is system.dll, it uses the new PluginAPI.h for basic types,
but has custom handling for its stack and vars handling (its version of getuservariable will allocate a new string and it does ugly stuff like "GlobalFree((HANDLE)pushstring(getuservariable(*(cmd++)-'0')))")
Some plugins (BgImage,InstallOptions,UserInfo,etc) manipulate "internal" globals like g_stacktop directly, I did not
try to change this, but at some point it should probably addressed so that PluginUtil.h is used instead of exdll.h
The patch was already uploaded as part of another patch and can be found @ http://sourceforge.net/tracker2/index.php?func=detail&aid=1912699&group_id=22049&atid=373087
Log in to post a comment.
