Menu ▾ ▴

#789 Typo in Finish.nsh causes var waste warning

closed-fixed
Amir Szekely
Modern UI (97)
5
2008-06-16
2008-06-16
Toby Malone
No

Line 26 of Contrib\Modern UI 2\Pages\Finish.nsh is

!ifndef MUI_FINISHPAGE_NOREBOORTSUPPORT

I think it's meant to read

!ifndef MUI_FINISHPAGE_NOREBOOTSUPPORT

otherwise the "mui.FinishPage.ReturnValue" is always created, even when it doesn't need to be. Which causes the following warning in the compilier

Variable "mui.FinishPage.ReturnValue" not referenced or never set, wasting memory!

Discussion

  • Amir Szekely

    Amir Szekely - 2008-06-16
    • labels: --> Modern UI
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     

  • Amir Szekely

    Amir Szekely - 2008-06-16

    Logged In: YES
    user_id=584402
    Originator: NO

    Thanks, fixed.

     

Log in to post a comment.

auth0 logo